Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AIP18 #2508

Merged
merged 73 commits into from May 1, 2019

Conversation

Projects
None yet
3 participants
@supaiku0
Copy link
Contributor

commented May 1, 2019

Summary

Implements AIP18.

A good amount of work towards AIP11 has been done as well, since AIP18 is limited to version 2 transactions and only supported when the new aip11 milestone is active (which is not before 2.6).

More functional tests will be added at a later time.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 1, 2019

The ci/circleci: test-node11-unit job is failing as of d8d55c00b2e009692e607b13c7488d9530954187. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian
Copy link
Collaborator

left a comment

Few minor changes.

Show resolved Hide resolved __tests__/helpers/transaction-factory.ts Outdated
Show resolved Hide resolved __tests__/helpers/transaction-factory.ts Outdated
Show resolved Hide resolved __tests__/helpers/transaction-factory.ts Outdated
Show resolved Hide resolved __tests__/helpers/transaction-factory.ts Outdated
Show resolved Hide resolved __tests__/integration/core-transaction-pool/__support__/setup.ts Outdated
Show resolved Hide resolved packages/crypto/src/transactions/deserializer.ts Outdated
Show resolved Hide resolved packages/crypto/src/transactions/serializer.ts Outdated
Show resolved Hide resolved packages/crypto/src/transactions/verifier.ts
Show resolved Hide resolved packages/crypto/src/transactions/verifier.ts
Show resolved Hide resolved packages/crypto/src/utils/index.ts Outdated

faustbrian added some commits May 1, 2019

@faustbrian faustbrian self-requested a review May 1, 2019

faustbrian added some commits May 1, 2019

@faustbrian
Copy link
Collaborator

left a comment

core-tester-cli needs a new MultiSignatureRegistrationCommand with a test for it.

@faustbrian
Copy link
Collaborator

left a comment

Few missing types.

Show resolved Hide resolved packages/core-state/src/wallets/wallet.ts Outdated
Show resolved Hide resolved packages/core-state/src/wallets/wallet.ts Outdated
Show resolved Hide resolved packages/core-state/src/wallets/wallet.ts Outdated
Show resolved Hide resolved packages/core-state/src/wallets/wallet.ts Outdated
Show resolved Hide resolved packages/core-state/src/wallets/wallet.ts Outdated
Show resolved Hide resolved packages/crypto/src/crypto/schnorr.ts Outdated
Show resolved Hide resolved packages/crypto/src/transactions/builders/transactions/transaction.ts Outdated
Show resolved Hide resolved packages/crypto/src/transactions/builders/transactions/transaction.ts Outdated
Show resolved Hide resolved packages/crypto/src/transactions/builders/transactions/transaction.ts Outdated
Show resolved Hide resolved packages/crypto/src/transactions/serializer.ts Outdated

@faustbrian faustbrian referenced this pull request May 1, 2019

Closed

Implement AIP18 #1590

@faustbrian faustbrian merged commit a4b9737 into develop May 1, 2019

10 of 12 checks passed

ci/circleci: test-node10-e2e Your CircleCI tests were canceled
Details
ci/circleci: test-node11-e2e Your CircleCI tests were canceled
Details
ci/circleci: test-node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the aip18 branch May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.