Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crypto): handle missing version #2525

Merged
merged 2 commits into from May 2, 2019

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

commented May 2, 2019

Summary

Also call applyV1Compatibility when the version is missing. This check somehow got lost after the AIP18 branch got merged.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 2, 2019

The ci/circleci: test-node11-integration-1 job is failing as of e31972e10570c7892a06d3af812f4baaa4bc7bae. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

1 similar comment
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 2, 2019

The ci/circleci: test-node11-integration-1 job is failing as of e31972e10570c7892a06d3af812f4baaa4bc7bae. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io

This comment has been minimized.

Copy link

commented May 2, 2019

Codecov Report

Merging #2525 into develop will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2525      +/-   ##
===========================================
+ Coverage    67.84%   67.85%   +<.01%     
===========================================
  Files          394      394              
  Lines         8683     8685       +2     
  Branches       408      448      +40     
===========================================
+ Hits          5891     5893       +2     
+ Misses        2735     2734       -1     
- Partials        57       58       +1
Impacted Files Coverage Δ
...transactions/src/handlers/delegate-registration.ts 54.05% <0%> (ø) ⬆️
packages/crypto/src/transactions/factory.ts 100% <100%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d933f...e31972e. Read the comment docs.

@faustbrian faustbrian merged commit df45f2d into ArkEcosystem:develop May 2, 2019

12 checks passed

ci/circleci: test-node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.