Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): enable ban rule for tslint #2527

Merged
merged 2 commits into from May 3, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

commented May 3, 2019

Summary

Enable the ban rule for tslint and ban the use of .forEach as it is slower than for-of loops.

https://palantir.github.io/tslint/rules/ban/

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 3, 2019

The ci/circleci: test-node10-integration-0 job is failing as of f37b872dc8684f3929682b48c45b46cf717453f4. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian faustbrian merged commit 28bf8b6 into develop May 3, 2019

11 of 12 checks passed

ci/circleci: test-node10-benchmark CircleCI is running your tests
Details
ci/circleci: test-node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the tslint-ban branch May 3, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 3, 2019

Codecov Report

Merging #2527 into develop will increase coverage by <.01%.
The diff coverage is 83.87%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2527      +/-   ##
===========================================
+ Coverage    67.84%   67.85%   +<.01%     
===========================================
  Files          394      394              
  Lines         8684     8655      -29     
  Branches       447      447              
===========================================
- Hits          5892     5873      -19     
+ Misses        2734     2724      -10     
  Partials        58       58
Impacted Files Coverage Δ
...database-postgres/src/repositories/transactions.ts 25.53% <ø> (+0.53%) ⬆️
packages/core-elasticsearch/src/indices/wallets.ts 0% <ø> (ø) ⬆️
...s/core-database-postgres/src/integrity-verifier.ts 5.63% <ø> (+0.15%) ⬆️
packages/core-tester-cli/src/signer.ts 90.47% <ø> (-0.44%) ⬇️
...ackages/core-database-postgres/src/models/model.ts 57.14% <ø> (-5.36%) ⬇️
packages/core-transaction-pool/src/storage.ts 100% <ø> (ø) ⬆️
...ges/crypto/src/transactions/types/multi-payment.ts 40.9% <ø> (+1.77%) ⬆️
packages/core-blockchain/src/blockchain.ts 58.33% <ø> (-0.29%) ⬇️
...core-api/src/versions/2/transactions/controller.ts 75% <ø> (ø) ⬆️
...ckages/core-p2p/src/socket-server/versions/peer.ts 76.47% <ø> (-0.46%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7c4cf2...617683a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.