Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
refactor(crypto): invalidate blocks with expired transactions #2528
The expiration is now height based, but it's still possible to forge expired transactions when bypassing the pool. This PR prevents expired transactions from entering the pool and blocks which contain expired transactions are now invalid.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
Yeah, updated the PR. I went with the schema approach first, because then I wouldnt need to touch the tx pool/block validation at all, but it turns out that there are too many edge cases which require more complex changes to handle expired transactions correctly.
@@ Coverage Diff @@ ## develop #2528 +/- ## =========================================== - Coverage 67.18% 67.17% -0.02% =========================================== Files 399 399 Lines 8758 8767 +9 Branches 453 415 -38 =========================================== + Hits 5884 5889 +5 - Misses 2819 2824 +5 + Partials 55 54 -1