Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup TODOs and FIXMEs #2530

Merged
merged 5 commits into from May 4, 2019

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

commented May 4, 2019

Summary

Removes and resolves obsolete TODOs and FIXMEs.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 4, 2019

The ci/circleci: test-node10-e2e job is failing as of 14fbe9030c166a44c6a6c2444204a2a8f7677789. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 4, 2019

The ci/circleci: test-node11-unit job is failing as of 9f63e918fa5230f91fb93ab694200ed05997a9b5. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

supaiku0 and others added some commits May 4, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 4, 2019

Codecov Report

Merging #2530 into develop will decrease coverage by <.01%.
The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2530      +/-   ##
===========================================
- Coverage    67.87%   67.86%   -0.01%     
===========================================
  Files          394      394              
  Lines         8656     8664       +8     
  Branches       408      411       +3     
===========================================
+ Hits          5875     5880       +5     
- Misses        2725     2727       +2     
- Partials        56       57       +1
Impacted Files Coverage Δ
packages/crypto/src/transactions/verifier.ts 87.5% <ø> (-0.97%) ⬇️
...s/core-blockchain/src/processor/block-processor.ts 91.89% <ø> (ø) ⬆️
packages/crypto/src/blocks/deserializer.ts 92.59% <ø> (ø) ⬆️
packages/core-blockchain/src/state-machine.ts 88.98% <ø> (ø) ⬆️
packages/core-blockchain/src/blockchain.ts 58.33% <ø> (ø) ⬆️
...ages/core-transactions/src/handlers/transaction.ts 53.84% <100%> (+1.21%) ⬆️
.../transactions/builders/transactions/transaction.ts 98.24% <100%> (-0.04%) ⬇️
packages/crypto/src/crypto/bip38.ts 100% <100%> (ø) ⬆️
packages/core-state/src/wallets/wallet-manager.ts 73.1% <100%> (-0.19%) ⬇️
packages/crypto/src/transactions/serializer.ts 87.39% <50%> (-0.64%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7129bb...40317ec. Read the comment docs.

@faustbrian faustbrian merged commit 728b2a9 into ArkEcosystem:develop May 4, 2019

12 checks passed

ci/circleci: test-node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.