Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): use memoization for block and transaction factory #2531

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@faustbrian
Copy link
Collaborator

commented May 4, 2019

Summary

Resolves #2481

To-Do

  • Resolve issues with tests (because of how our tests work and modify data the memoization causes issues)
  • Add more tests for the block and transaction factory

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 4, 2019

The ci/circleci: test-node10-functional job is failing as of cfb0420578bbeab781868c1489b90c97fae32444. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.