Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): let the process manager extend @faustbrian/foreman #2536

Merged
merged 8 commits into from May 7, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

commented May 7, 2019

Summary

Extracted the process manager into a package because it will be used in other projects too.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 7, 2019

The ci/circleci: test-node11-integration-0 job is failing as of 28cb7216bd33daa703c8a65c86e9c02049abcdf6. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io

This comment has been minimized.

Copy link

commented May 7, 2019

Codecov Report

Merging #2536 into develop will increase coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2536      +/-   ##
===========================================
+ Coverage    67.35%   67.48%   +0.13%     
===========================================
  Files          400      400              
  Lines         8805     8788      -17     
  Branches       454      455       +1     
===========================================
  Hits          5931     5931              
+ Misses        2818     2801      -17     
  Partials        56       56
Impacted Files Coverage Δ
packages/core/src/commands/core/run.ts 0% <ø> (ø) ⬆️
packages/core/src/commands/core/start.ts 0% <ø> (ø) ⬆️
packages/core/src/shared/status.ts 0% <ø> (ø) ⬆️
packages/core/src/commands/forger/start.ts 0% <ø> (ø) ⬆️
packages/core/src/commands/relay/start.ts 0% <ø> (ø) ⬆️
packages/core/src/commands/relay/run.ts 0% <ø> (ø) ⬆️
packages/core/src/commands/top.ts 0% <0%> (ø) ⬆️
packages/core/src/commands/config/forger/bip38.ts 0% <0%> (ø) ⬆️
packages/core/src/commands/forger/run.ts 0% <0%> (ø) ⬆️
packages/core/src/commands/command.ts 0% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d78da0...28cb721. Read the comment docs.

faustbrian and others added some commits May 7, 2019

@faustbrian faustbrian merged commit fc035f2 into develop May 7, 2019

12 checks passed

ci/circleci: test-node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/core-foreman branch May 7, 2019

vasild added a commit that referenced this pull request May 8, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into feat/de…
…legate-resignation

* ArkEcosystem/core/develop:
  chore(deps): update and remove unused dependencies (#2546)
  release: 2.4.0-next.2 (#2545)
  feat(core-wallet-api): initial implementation (#2544)
  fix(core): use the --env flag to start testnet via CLI (#2543)
  release: 2.4.0-next.1 (#2541)
  refactor(core-database-postgres): transaction type agnostic wallet bootstrap (#2539)
  release: 2.4.0-next.0 (#2540)
  refactor(core): let the process manager extend @faustbrian/foreman (#2536)
  feat: Implement IPFS (AIP11) (#2537)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.