Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-database-postgres): wallets bootstrap #2539

Merged
merged 10 commits into from May 8, 2019

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

commented May 8, 2019

Summary

Changes how the IntegrityVerifier (now called StateBuilder) builds the wallets. Now each transaction handler has a bootstrap function which is invoked during state building and performs the actual work. Since it is now transaction agnostic, custom transaction types are automatically picked up during bootstrap.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 8, 2019

The ci/circleci: test-node11-e2e job is failing as of 0754fe978d1a8b79a75e566bbcb0b6a207a6eb31. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io

This comment has been minimized.

Copy link

commented May 8, 2019

Codecov Report

Merging #2539 into develop will decrease coverage by 0.06%.
The diff coverage is 7.86%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2539      +/-   ##
===========================================
- Coverage    67.48%   67.42%   -0.07%     
===========================================
  Files          400      400              
  Lines         8788     8798      +10     
  Branches       455      416      -39     
===========================================
+ Hits          5931     5932       +1     
- Misses        2801     2812      +11     
+ Partials        56       54       -2
Impacted Files Coverage Δ
...ages/core-transactions/src/handlers/transaction.ts 53.84% <ø> (ø) ⬆️
...core-transactions/src/handlers/handler-registry.ts 93.18% <0%> (-2.17%) ⬇️
...ase/src/repositories/blocks-business-repository.ts 66.66% <0%> (-13.34%) ⬇️
...core-transactions/src/handlers/second-signature.ts 68.42% <0%> (-12.83%) ⬇️
packages/core-transactions/src/handlers/ipfs.ts 78.94% <0%> (-14.81%) ⬇️
...es/core-transactions/src/handlers/multi-payment.ts 50% <0%> (-7.15%) ⬇️
.../core-database-postgres/src/repositories/blocks.ts 27.77% <0%> (-2.53%) ⬇️
...c/repositories/transactions-business-repository.ts 92.85% <0%> (-4.16%) ⬇️
...transactions/src/handlers/delegate-registration.ts 40% <0%> (-14.06%) ⬇️
...-transactions/src/handlers/delegate-resignation.ts 44.44% <0%> (-5.56%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc035f2...1c7b828. Read the comment docs.

@faustbrian faustbrian merged commit afb69f2 into develop May 8, 2019

0 of 12 checks passed

ci/circleci: test-node11-integration-1 Your tests failed on CircleCI
Details
ci/circleci: test-node10-benchmark CircleCI is running your tests
Details
ci/circleci: test-node10-e2e CircleCI is running your tests
Details
ci/circleci: test-node10-functional CircleCI is running your tests
Details
ci/circleci: test-node10-integration-0 Your tests are queued behind your running builds
Details
ci/circleci: test-node10-integration-1 CircleCI is running your tests
Details
ci/circleci: test-node10-unit Your tests are queued behind your running builds
Details
ci/circleci: test-node11-benchmark CircleCI is running your tests
Details
ci/circleci: test-node11-e2e Your tests are queued behind your running builds
Details
ci/circleci: test-node11-functional CircleCI is running your tests
Details
ci/circleci: test-node11-integration-0 Your tests are queued behind your running builds
Details
ci/circleci: test-node11-unit CircleCI is running your tests
Details

@ArkEcosystemBot ArkEcosystemBot deleted the tx-bootstrap branch May 8, 2019

vasild added a commit that referenced this pull request May 8, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into feat/de…
…legate-resignation

* ArkEcosystem/core/develop:
  chore(deps): update and remove unused dependencies (#2546)
  release: 2.4.0-next.2 (#2545)
  feat(core-wallet-api): initial implementation (#2544)
  fix(core): use the --env flag to start testnet via CLI (#2543)
  release: 2.4.0-next.1 (#2541)
  refactor(core-database-postgres): transaction type agnostic wallet bootstrap (#2539)
  release: 2.4.0-next.0 (#2540)
  refactor(core): let the process manager extend @faustbrian/foreman (#2536)
  feat: Implement IPFS (AIP11) (#2537)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.