Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 2.4.0-next.0 #2540

Merged
merged 3 commits into from May 8, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

commented May 8, 2019

Summary

Release 2.4.0-next.0.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet (mainnet has no websockets so a sync is not possible)
    • Sync from 0 works on devnet (devnet has no websockets so a sync is not possible)
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional (Wallets relied on a P2P API Endpoint)
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 8, 2019

The ci/circleci: test-node11-functional job is failing as of 51006c3f3cdc5c7e47a96d264fa7eee08cc1752a. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io

This comment has been minimized.

Copy link

commented May 8, 2019

Codecov Report

Merging #2540 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2540   +/-   ##
========================================
  Coverage    67.48%   67.48%           
========================================
  Files          400      400           
  Lines         8788     8788           
  Branches       455      455           
========================================
  Hits          5931     5931           
  Misses        2801     2801           
  Partials        56       56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc035f2...e9794cc. Read the comment docs.

@faustbrian faustbrian merged commit f519b4a into develop May 8, 2019

12 checks passed

ci/circleci: test-node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the release/2.4.0-next.0 branch May 8, 2019

vasild added a commit that referenced this pull request May 8, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into feat/de…
…legate-resignation

* ArkEcosystem/core/develop:
  chore(deps): update and remove unused dependencies (#2546)
  release: 2.4.0-next.2 (#2545)
  feat(core-wallet-api): initial implementation (#2544)
  fix(core): use the --env flag to start testnet via CLI (#2543)
  release: 2.4.0-next.1 (#2541)
  refactor(core-database-postgres): transaction type agnostic wallet bootstrap (#2539)
  release: 2.4.0-next.0 (#2540)
  refactor(core): let the process manager extend @faustbrian/foreman (#2536)
  feat: Implement IPFS (AIP11) (#2537)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.