Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/testnet #2542

Closed
wants to merge 124 commits into from

Conversation

Projects
None yet
7 participants
@faustbrian
Copy link
Collaborator

commented May 8, 2019

Summary

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

air1one and others added some commits Apr 2, 2019

@air1one

This comment was marked as resolved.

Copy link
Collaborator

commented on packages/core-p2p/src/socket-server/worker.ts in 37ea8a3 Apr 9, 2019

You can't do req.socket in handshake because underlying socket doesn't exist yet, just return next(new Error(...)) like below.
(https://socketcluster.io/#!/docs/middleware-and-authorization)

air1one and others added some commits Apr 9, 2019

faustbrian and others added some commits May 2, 2019

@faustbrian faustbrian requested review from kristjank and supaiku0 as code owners May 8, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 8, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 8, 2019

The ci/circleci: test-node11-e2e job is failing as of 6e16d4ea32b7150becdb69a689175dbddb8a5f11. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.