Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update and remove unused dependencies #2546

Merged
merged 2 commits into from May 8, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

commented May 8, 2019

Summary

Update dependencies and remove a bunch of old and unused things.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@codecov-io

This comment has been minimized.

Copy link

commented May 8, 2019

Codecov Report

Merging #2546 into develop will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2546      +/-   ##
===========================================
- Coverage    67.33%   67.31%   -0.02%     
===========================================
  Files          402      402              
  Lines         8810     8812       +2     
  Branches       416      456      +40     
===========================================
  Hits          5932     5932              
  Misses        2824     2824              
- Partials        54       56       +2
Impacted Files Coverage Δ
packages/core-elasticsearch/src/server.ts 0% <0%> (ø) ⬆️
packages/core-elasticsearch/src/client.ts 0% <0%> (ø) ⬆️
packages/core-elasticsearch/src/indices/base.ts 0% <0%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️
...es/core-blockchain/src/replay/replay-blockchain.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78b7623...5ebc979. Read the comment docs.

@faustbrian faustbrian marked this pull request as ready for review May 8, 2019

@faustbrian faustbrian merged commit 30a3723 into develop May 8, 2019

0 of 12 checks passed

ci/circleci: test-node10-benchmark CircleCI is running your tests
Details
ci/circleci: test-node10-e2e CircleCI is running your tests
Details
ci/circleci: test-node10-functional CircleCI is running your tests
Details
ci/circleci: test-node10-integration-0 CircleCI is running your tests
Details
ci/circleci: test-node10-integration-1 CircleCI is running your tests
Details
ci/circleci: test-node10-unit Your tests are queued behind your running builds
Details
ci/circleci: test-node11-benchmark CircleCI is running your tests
Details
ci/circleci: test-node11-e2e CircleCI is running your tests
Details
ci/circleci: test-node11-functional Your tests are queued behind your running builds
Details
ci/circleci: test-node11-integration-0 Your tests are queued behind your running builds
Details
ci/circleci: test-node11-integration-1 Your tests are queued behind your running builds
Details
ci/circleci: test-node11-unit CircleCI is running your tests
Details

@ArkEcosystemBot ArkEcosystemBot deleted the deps branch May 8, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 8, 2019

The ci/circleci: test-node11-integration-0 job is failing as of 223e7b784b0e0209572b5f8da61e5deb360ab10a. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

vasild added a commit that referenced this pull request May 8, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into feat/de…
…legate-resignation

* ArkEcosystem/core/develop:
  chore(deps): update and remove unused dependencies (#2546)
  release: 2.4.0-next.2 (#2545)
  feat(core-wallet-api): initial implementation (#2544)
  fix(core): use the --env flag to start testnet via CLI (#2543)
  release: 2.4.0-next.1 (#2541)
  refactor(core-database-postgres): transaction type agnostic wallet bootstrap (#2539)
  release: 2.4.0-next.0 (#2540)
  refactor(core): let the process manager extend @faustbrian/foreman (#2536)
  feat: Implement IPFS (AIP11) (#2537)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.