Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-p2p): ignore maxSameSubnetPeers in seed mode #2547

Merged

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

commented May 8, 2019

Summary

Ignore maxSameSubnetPeers in seed mode.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@codecov-io

This comment has been minimized.

Copy link

commented May 8, 2019

Codecov Report

Merging #2547 into develop will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2547      +/-   ##
===========================================
- Coverage    67.31%   67.31%   -0.01%     
===========================================
  Files          402      402              
  Lines         8812     8814       +2     
  Branches       456      418      -38     
===========================================
+ Hits          5932     5933       +1     
- Misses        2824     2827       +3     
+ Partials        56       54       -2
Impacted Files Coverage Δ
packages/core-p2p/src/peer-processors.ts 58.1% <50%> (-0.23%) ⬇️
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️
...es/core-blockchain/src/replay/replay-blockchain.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30a3723...bd4f9d0. Read the comment docs.

@faustbrian faustbrian merged commit 6658860 into ArkEcosystem:develop May 8, 2019

vasild added a commit that referenced this pull request May 8, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into feat/de…
…legate-resignation

* ArkEcosystem/core/develop:
  release: 2.4.0-next.3 (#2549)
  refactor(core-p2p): reduce log noise (#2548)
  fix(core-p2p): ignore maxSameSubnetPeers in seed mode (#2547)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.