Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-p2p): reduce p2p noise #2548

merged 1 commit into from May 8, 2019


None yet
4 participants
Copy link

commented May 8, 2019


Disables logging of invalid peer versions and subnets for now until we come up with a better solution, but right now the logs are unreadable because of all the spam.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No


  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@faustbrian faustbrian merged commit 7dde7b7 into ArkEcosystem:develop May 8, 2019


This comment has been minimized.

Copy link

commented May 8, 2019

Codecov Report

Merging #2548 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2548      +/-   ##
+ Coverage    67.31%   67.32%   +0.01%     
  Files          402      402              
  Lines         8814     8811       -3     
  Branches       418      458      +40     
- Hits          5933     5932       -1     
+ Misses        2827     2823       -4     
- Partials        54       56       +2
Impacted Files Coverage Δ
packages/core-p2p/src/peer-processors.ts 59.15% <ø> (+1.04%) ⬆️
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️ 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6658860...6979b13. Read the comment docs.

vasild added a commit that referenced this pull request May 8, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into feat/de…

* ArkEcosystem/core/develop:
  release: 2.4.0-next.3 (#2549)
  refactor(core-p2p): reduce log noise (#2548)
  fix(core-p2p): ignore maxSameSubnetPeers in seed mode (#2547)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.