Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 2.4.0-next.3 #2549

Merged
merged 1 commit into from May 8, 2019

Conversation

Projects
None yet
2 participants
@faustbrian
Copy link
Collaborator

commented May 8, 2019

Summary

Release 2.4.0-next.3 with a last minute change for wallets.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet (mainnet has no websockets so a sync is not possible)
    • Sync from 0 works on devnet (devnet has no websockets so a sync is not possible)
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional (Wallets relied on a P2P API Endpoint)
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@faustbrian faustbrian merged commit 16ed284 into develop May 8, 2019

@ArkEcosystemBot ArkEcosystemBot deleted the release/2.4.0-next.3 branch May 8, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 8, 2019

The ci/circleci: test-node11-integration-1 job is failing as of 908a21725241c9d14531808c1467bd1b680bbfc2. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

vasild added a commit that referenced this pull request May 8, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into feat/de…
…legate-resignation

* ArkEcosystem/core/develop:
  release: 2.4.0-next.3 (#2549)
  refactor(core-p2p): reduce log noise (#2548)
  fix(core-p2p): ignore maxSameSubnetPeers in seed mode (#2547)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.