Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-p2p): remove peer.os property #2552

Merged
merged 1 commit into from May 8, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

commented May 8, 2019

Summary

Remove the os property from a peer as it isn't used for anything, was a leftover from ark-node.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@codecov-io

This comment has been minimized.

Copy link

commented May 8, 2019

Codecov Report

Merging #2552 into develop will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2552      +/-   ##
===========================================
- Coverage    67.32%   67.07%   -0.26%     
===========================================
  Files          402      418      +16     
  Lines         8811     8944     +133     
  Branches       458      459       +1     
===========================================
+ Hits          5932     5999      +67     
- Misses        2823     2887      +64     
- Partials        56       58       +2
Impacted Files Coverage Δ
...kages/core-api/src/versions/1/peers/transformer.ts 100% <ø> (ø) ⬆️
packages/core-api/src/versions/1/peers/schema.ts 100% <ø> (ø) ⬆️
packages/core-p2p/src/peer.ts 100% <ø> (ø) ⬆️
...kages/core-api/src/versions/2/peers/transformer.ts 66.66% <ø> (ø) ⬆️
...ckages/core-p2p/src/socket-server/versions/peer.ts 76.47% <ø> (ø) ⬆️
...re-p2p/src/socket-server/utils/validate-headers.ts 50% <ø> (ø) ⬆️
...ckages/core-api/src/versions/2/peers/controller.ts 65.51% <ø> (-2.23%) ⬇️
...es/core-p2p/src/socket-server/utils/get-headers.ts 100% <ø> (ø) ⬆️
packages/core-p2p/src/peer-communicator.ts 79.22% <ø> (ø) ⬆️
...ckages/core-api/src/versions/1/peers/controller.ts 68.96% <ø> (-2.01%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ed284...22edb2e. Read the comment docs.

@supaiku0 supaiku0 merged commit 14f705f into develop May 8, 2019

12 checks passed

ci/circleci: test-node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/p2p-os branch May 8, 2019

supaiku0 added a commit to supaiku0/core that referenced this pull request May 8, 2019

@supaiku0 supaiku0 referenced this pull request May 8, 2019

Merged

revert(core-p2p): peer header changes #2554

0 of 22 tasks complete

supaiku0 added a commit that referenced this pull request May 8, 2019

faustbrian added a commit that referenced this pull request May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.