Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-p2p): remove peer.nethash property #2553

Merged
merged 4 commits into from May 8, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

commented May 8, 2019

Summary

Remove the peer.nethash property and instead let the peer verifier decide if a peer is on the same network as we are.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 8, 2019

The ci/circleci: test-node11-unit job is failing as of 4d20ce366a936d338ba1110cbafbdd6c5f695051. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

faustbrian added some commits May 8, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 8, 2019

Codecov Report

Merging #2553 into develop will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #2553      +/-   ##
==========================================
+ Coverage    67.07%   67.3%   +0.23%     
==========================================
  Files          418     402      -16     
  Lines         8944    8800     -144     
  Branches       459     416      -43     
==========================================
- Hits          5999    5923      -76     
+ Misses        2887    2824      -63     
+ Partials        58      53       -5
Impacted Files Coverage Δ
packages/core-p2p/src/peer-communicator.ts 79.22% <ø> (ø) ⬆️
...es/core-p2p/src/socket-server/utils/get-headers.ts 100% <ø> (ø) ⬆️
packages/core-p2p/src/peer-guard.ts 75.67% <ø> (-4.33%) ⬇️
packages/core-p2p/src/peer.ts 100% <ø> (ø) ⬆️
...ckages/core-p2p/src/socket-server/versions/peer.ts 76.47% <ø> (ø) ⬆️
packages/core-forger/src/client.ts 65.9% <ø> (ø) ⬆️
...re-p2p/src/socket-server/utils/validate-headers.ts 50% <ø> (ø) ⬆️
packages/core-p2p/src/peer-processors.ts 61.19% <ø> (+2.03%) ⬆️
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14f705f...f3faa84. Read the comment docs.

@faustbrian faustbrian merged commit 7d1bbd2 into develop May 8, 2019

12 checks passed

ci/circleci: test-node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/p2p-nethash branch May 8, 2019

@supaiku0 supaiku0 referenced this pull request May 8, 2019

Merged

revert(core-p2p): peer header changes #2554

0 of 22 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.