Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add db configuration command #2557

Merged
merged 12 commits into from May 10, 2019

Conversation

@dated
Copy link
Contributor

commented May 9, 2019

Summary

Adds a new config command to the cli so that the database can be easily configured.

ark config:database --host=localhost --port=5432 --username=ark --database=ark_mainnet --password=password

Configuring the database credentials is possible already through the cli by setting the respective environment variables. This however requires knowledge over these variable names.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Other information

The CLI does not interact with the database in any way; changing the database name for instance will not rename the postgres database itself.

dated added some commits May 8, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 9, 2019

The ci/circleci: test-node11-integration-0 job is failing as of 6f44cd36c798cb2aa4d5b0f4d7800c5818f64ccf. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

dated added some commits May 9, 2019

@dated dated marked this pull request as ready for review May 9, 2019

@dated dated requested review from air1one, kristjank and supaiku0 as code owners May 9, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 10, 2019

Your pull request needs some changes. Please wait for a comment from one of our developers for more information.

@faustbrian
Copy link
Collaborator

left a comment

Command should be renamed to config:database to avoid unnecessary abbreviations.

@faustbrian faustbrian requested review from supaiku0 and faustbrian May 10, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 10, 2019

A collaborator has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit 093e4c0 into ArkEcosystem:develop May 10, 2019

12 checks passed

ci/circleci: test-node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 10, 2019

Your pull request has been merged and marked as tier 2. It will earn you $50 USD.

@faustbrian faustbrian referenced this pull request May 10, 2019

Merged

feat(core): interactive database configuration #2563

5 of 22 tasks complete

@dated dated deleted the dated:feat/db-config branch May 10, 2019

@dated dated referenced this pull request May 10, 2019

Merged

docs: add config:database command #405

3 of 10 tasks complete

vasild added a commit that referenced this pull request May 10, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into feat/de…
…legate-resignation

* ArkEcosystem/core/develop:
  feat(core): add database configuration command (#2557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.