Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-wallets-api): proxy API calls to core-api until fully developed #2558

Merged
merged 2 commits into from May 9, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

commented May 9, 2019

Summary

Proxy all calls to 4040 to 4003 locally until the Wallet API is fully developed.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@codecov-io

This comment has been minimized.

Copy link

commented May 9, 2019

Codecov Report

Merging #2558 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2558   +/-   ##
========================================
  Coverage    67.31%   67.31%           
========================================
  Files          402      402           
  Lines         8803     8803           
  Branches       454      454           
========================================
  Hits          5926     5926           
  Misses        2822     2822           
  Partials        55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd6a5c...a17a8d5. Read the comment docs.

1 similar comment
@codecov-io

This comment has been minimized.

Copy link

commented May 9, 2019

Codecov Report

Merging #2558 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2558   +/-   ##
========================================
  Coverage    67.31%   67.31%           
========================================
  Files          402      402           
  Lines         8803     8803           
  Branches       454      454           
========================================
  Hits          5926     5926           
  Misses        2822     2822           
  Partials        55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd6a5c...a17a8d5. Read the comment docs.

@faustbrian faustbrian marked this pull request as ready for review May 9, 2019

@faustbrian faustbrian merged commit a7ced36 into develop May 9, 2019

12 checks passed

ci/circleci: test-node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the wallet-api-rpoxy branch May 9, 2019

vasild added a commit that referenced this pull request May 9, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into feat/de…
…legate-resignation

* ArkEcosystem/core/develop:
  feat(core-wallets-api): proxy API calls to core-api until fully developed (#2558)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.