Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-p2p): socketcluster shutdown and logging #2560

Merged
merged 11 commits into from May 10, 2019

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

commented May 10, 2019

Summary

Removes a bunch of redundant logging and error stacks due to an unclean shutdown of the socketcluster.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 10, 2019

The ci/circleci: test-node11-e2e job is failing as of 78697dc9fce46dd69c0a3d7d2ef37c5c2b5ae1d1. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 10, 2019

The ci/circleci: test-node10-functional job is failing as of 75b0fe92bcd91bb4585265c7f8358b09300e71b2. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

supaiku0 and others added some commits May 10, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 10, 2019

Codecov Report

Merging #2560 into develop will decrease coverage by 0.09%.
The diff coverage is 29.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #2560     +/-   ##
==========================================
- Coverage    66.91%   66.82%   -0.1%     
==========================================
  Files          406      406             
  Lines         8854     8864     +10     
  Branches       419      460     +41     
==========================================
- Hits          5925     5923      -2     
- Misses        2876     2886     +10     
- Partials        53       55      +2
Impacted Files Coverage Δ
packages/core-p2p/src/peer-connector.ts 95.83% <ø> (-0.47%) ⬇️
packages/core-container/src/container.ts 51.66% <0%> (+0.84%) ⬆️
packages/core-p2p/src/event-listener.ts 16.66% <0%> (-8.34%) ⬇️
packages/core-p2p/src/peer-guard.ts 75.67% <100%> (ø) ⬆️
packages/core-p2p/src/peer-communicator.ts 77.21% <100%> (-2.01%) ⬇️
packages/core-p2p/src/network-monitor.ts 64.67% <25%> (-1.08%) ⬇️
packages/core-forger/src/client.ts 64.44% <25%> (-1.47%) ⬇️
packages/core-forger/src/manager.ts 54.73% <40%> (-1.18%) ⬇️
packages/core-p2p/src/peer-processors.ts 60.86% <66.66%> (-0.33%) ⬇️
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bea3ff...f133916. Read the comment docs.

@faustbrian faustbrian merged commit 0f6b217 into ArkEcosystem:develop May 10, 2019

12 checks passed

ci/circleci: test-node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.