Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): interactive database configuration #2563

Merged
merged 3 commits into from May 10, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

commented May 10, 2019

Summary

Cleans up #2557 and adds an interactive mode.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
Show resolved Hide resolved packages/core/src/commands/config/database.ts Outdated
Show resolved Hide resolved packages/core/src/commands/config/database.ts Outdated
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 10, 2019

Your pull request needs some changes. Please wait for a comment from one of our developers for more information.

@dated

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

I guess the names used inside of prompts need to be adjusted as well.

@codecov-io

This comment has been minimized.

Copy link

commented May 10, 2019

Codecov Report

Merging #2563 into develop will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2563      +/-   ##
===========================================
- Coverage    67.15%   67.13%   -0.02%     
===========================================
  Files          403      403              
  Lines         8825     8827       +2     
  Branches       454      417      -37     
===========================================
  Hits          5926     5926              
- Misses        2844     2848       +4     
+ Partials        55       53       -2
Impacted Files Coverage Δ
packages/core/src/utils.ts 0% <0%> (ø) ⬆️
packages/core/src/commands/config/database.ts 0% <0%> (ø) ⬆️
packages/core/src/commands/env/set.ts 0% <0%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️
...es/core-blockchain/src/replay/replay-blockchain.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 093e4c0...757c6d3. Read the comment docs.

Update packages/core/src/commands/config/database.ts
Co-Authored-By: Edgar Goetzendorff <hello@dated.fun>

@dated dated referenced this pull request May 10, 2019

Merged

docs: add config:database command #405

3 of 10 tasks complete

@faustbrian faustbrian merged commit 1ad8526 into develop May 10, 2019

12 checks passed

ci/circleci: test-node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the feat/db-interactive branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.