Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change hasExceededMaxTransactions()'s argument type #2568

Merged
merged 2 commits into from May 13, 2019

Conversation

Projects
None yet
4 participants
@vasild
Copy link
Contributor

commented May 13, 2019

refactor: change hasExceededMaxTransactions()'s argument type

hasExceededMaxTransactions() was taking an argument of type
Interfaces.ITransactionData and was just using its .senderPublicKey
member. Change it to take "senderPublicKey: string".

This makes it easier to use hasExceededMaxTransactions() from unit tests
with bogus senderPublicKey because no dummy transaction object is
necessary.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@vasild vasild force-pushed the fix-hasExceededMaxTransactions branch 2 times, most recently from 00b3a34 to cd443f4 May 13, 2019

@vasild vasild changed the title wip refactor: change hasExceededMaxTransactions()'s argument type May 13, 2019

refactor: change hasExceededMaxTransactions()'s argument type
hasExceededMaxTransactions() was taking an argument of type
Interfaces.ITransactionData and was just using its .senderPublicKey
member. Change it to take "senderPublicKey: string".

This makes it easier to use hasExceededMaxTransactions() from unit tests
with bogus senderPublicKey because no dummy transaction object is
necessary.

@vasild vasild force-pushed the fix-hasExceededMaxTransactions branch from cd443f4 to feec6f1 May 13, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 13, 2019

Codecov Report

Merging #2568 into develop will decrease coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2568      +/-   ##
===========================================
- Coverage    66.82%   66.61%   -0.22%     
===========================================
  Files          406      422      +16     
  Lines         8883     9018     +135     
  Branches       460      463       +3     
===========================================
+ Hits          5936     6007      +71     
- Misses        2892     2954      +62     
- Partials        55       57       +2
Impacted Files Coverage Δ
packages/core-transaction-pool/src/processor.ts 80.26% <ø> (ø) ⬆️
packages/core-transaction-pool/src/connection.ts 95.59% <100%> (ø) ⬆️
...s/core-interfaces/src/core-database/event-types.ts 0% <0%> (ø)
packages/core-transaction-pool/src/plugin.ts 100% <0%> (ø)
...aces/src/core-database/search/search-parameters.ts 0% <0%> (ø)
packages/core-blockchain/src/plugin.ts 0% <0%> (ø)
packages/core-wallet-api/src/plugin.ts 0% <0%> (ø)
packages/core-logger-winston/src/plugin.ts 75% <0%> (ø)
packages/core-logger-pino/src/plugin.ts 75% <0%> (ø)
packages/core-p2p/src/plugin.ts 65.51% <0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b229a...267bed2. Read the comment docs.

@faustbrian faustbrian merged commit 466d4df into develop May 13, 2019

12 checks passed

ci/circleci: test-node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix-hasExceededMaxTransactions branch May 13, 2019

vasild added a commit that referenced this pull request May 13, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into nonces
* ArkEcosystem/core/develop:
  fix(core-blockchain): use resolveOptions("blockchain") to get databaseRollback options (#2572)
  refactor: change hasExceededMaxTransactions()'s argument type (#2568)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.