Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blockchain): use resolveOptions("blockchain") to get databaseRollback options #2572

Merged
merged 4 commits into from May 13, 2019

Conversation

Projects
None yet
4 participants
@air1one
Copy link
Collaborator

commented May 13, 2019

Summary

Use resolveOptions("blockchain") to get databaseRollback options. (instead of resolveOptions("p2p") which was not getting anything)

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@codecov-io

This comment has been minimized.

Copy link

commented May 13, 2019

Codecov Report

Merging #2572 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2572   +/-   ##
========================================
  Coverage    66.82%   66.82%           
========================================
  Files          406      406           
  Lines         8883     8883           
  Branches       460      460           
========================================
  Hits          5936     5936           
  Misses        2892     2892           
  Partials        55       55
Impacted Files Coverage Δ
packages/core-blockchain/src/state-machine.ts 88.98% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 466d4df...913138a. Read the comment docs.

faustbrian added some commits May 13, 2019

@faustbrian faustbrian merged commit e1111a5 into develop May 13, 2019

12 checks passed

ci/circleci: test-node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/blockchain-rollback-options branch May 13, 2019

vasild added a commit that referenced this pull request May 13, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into nonces
* ArkEcosystem/core/develop:
  fix(core-blockchain): use resolveOptions("blockchain") to get databaseRollback options (#2572)
  refactor: change hasExceededMaxTransactions()'s argument type (#2568)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.