Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core-transaction-pool): polish stress test and don't clock the TransactionFactory #2575

Merged
merged 1 commit into from May 13, 2019

Conversation

Projects
None yet
4 participants
@vasild
Copy link
Contributor

commented May 13, 2019

  • Properly use TransactionFactory to generate transactions with
    different ids instead of manually overriding the "id" member. Add a
    generateTestTransactions() method, used in all 3 stress tests.

  • The overall timing of "✓ multiple additions and retrievals (884ms)" is
    now not sufficient to assess the speed of the add+retrieve of the pool
    because it includes generating the test transactions with
    TransactionFactory which is about 11 times slower than the actual
    add+retrieve that is done by the test. Thus clock only the relevant
    snippet of the code with console.time().

test: polish tx pool stress test and don't clock the TransactionFactory
* Properly use TransactionFactory to generate transactions with
  different ids instead of manually overriding the "id" member. Add a
  generateTestTransactions() method, used in all 3 stress tests.

* The overall timing of "✓ multiple additions and retrievals (884ms)" is
  now not sufficient to assess the speed of the add+retrieve of the pool
  because it includes generating the test transactions with
  TransactionFactory which is about 11 times slower than the actual
  add+retrieve that is done by the test. Thus clock only the relevant
  snippet of the code with console.time().

@faustbrian faustbrian changed the title test: polish tx pool stress test and don't clock the TransactionFactory test(core-transaction-pool): polish stress test and don't clock the TransactionFactory May 13, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 13, 2019

Codecov Report

Merging #2575 into develop will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2575      +/-   ##
===========================================
+ Coverage    66.61%   66.82%   +0.21%     
===========================================
  Files          422      406      -16     
  Lines         9018     8883     -135     
  Branches       463      419      -44     
===========================================
- Hits          6007     5936      -71     
+ Misses        2954     2894      -60     
+ Partials        57       53       -4
Impacted Files Coverage Δ
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️
...es/core-blockchain/src/replay/replay-blockchain.ts 0% <0%> (ø) ⬆️
...s/core-interfaces/src/core-database/event-types.ts
packages/core-transaction-pool/src/plugin.ts
...aces/src/core-database/search/search-parameters.ts
packages/core-blockchain/src/plugin.ts
packages/core-wallet-api/src/plugin.ts
packages/core-logger-winston/src/plugin.ts
packages/core-logger-pino/src/plugin.ts
packages/core-p2p/src/plugin.ts
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1111a5...9c477dc. Read the comment docs.

@faustbrian faustbrian merged commit d2b426e into develop May 13, 2019

12 checks passed

ci/circleci: test-node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: test-node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the test-polish-tx-pool-stress branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.