Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-api): remove the legacy API #2577

wants to merge 15 commits into
base: develop


None yet
3 participants
Copy link

commented May 13, 2019


Removes the legacy API of ark-node which ends support for applications that still use it and the legacy RPC.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No


  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

faustbrian added some commits Apr 18, 2019

@faustbrian faustbrian changed the title refactor(corer-api): remove the legacy API refactor(core-api): remove the legacy API May 13, 2019


This comment has been minimized.

Copy link

commented May 14, 2019

Codecov Report

Merging #2577 into develop will decrease coverage by 1.06%.
The diff coverage is 75.28%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2577      +/-   ##
- Coverage     65.8%   64.74%   -1.07%     
  Files          408      369      -39     
  Lines         9001     8310     -691     
  Branches       416      381      -35     
- Hits          5923     5380     -543     
+ Misses        3026     2891     -135     
+ Partials        52       39      -13
Impacted Files Coverage Δ
...ages/core-api/src/handlers/delegates/controller.ts 72.22% <ø> (ø)
...ackages/core-api/src/handlers/rounds/controller.ts 83.33% <ø> (ø)
...s/core-api/src/handlers/shared/schemas/block-id.ts 100% <ø> (ø)
...core-api/src/handlers/shared/transformers/ports.ts 70% <ø> (ø)
packages/core-api/src/handlers/votes/schema.ts 100% <ø> (ø)
packages/core-api/src/handlers/votes/routes.ts 100% <ø> (ø)
packages/core-api/src/handlers/wallets/schema.ts 100% <ø> (ø)
...ckages/core-api/src/handlers/wallets/controller.ts 70.37% <ø> (ø)
packages/core-api/src/handlers/wallets/routes.ts 100% <ø> (ø)
...ackages/core-api/src/handlers/blocks/controller.ts 73.33% <ø> (ø)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37c3b3a...73b9200. Read the comment docs.


This comment has been minimized.

Copy link

commented May 14, 2019

The ci/circleci: test-node11-e2e job is failing as of 71a615050119f12b8314eb6a9b46c102e653720c. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

faustbrian added some commits May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.