Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-api): register /api/v2 as a transition period fallback #2578

Merged
merged 2 commits into from May 14, 2019

Conversation

Projects
None yet
2 participants
@faustbrian
Copy link
Collaborator

commented May 14, 2019

Summary

Support /api and /api/v2 as some people use the URL paths even though the docs advise against it.

This will be removed with the release of 3.0 later this year and only /api will be supported.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@faustbrian faustbrian merged commit f2ebebc into 2.5 May 14, 2019

0 of 10 checks passed

ci/circleci: test-node10-benchmark Your tests are queued behind your running builds
Details
ci/circleci: test-node10-functional CircleCI is running your tests
Details
ci/circleci: test-node10-integration-0 CircleCI is running your tests
Details
ci/circleci: test-node10-integration-1 CircleCI is running your tests
Details
ci/circleci: test-node10-unit CircleCI is running your tests
Details
ci/circleci: test-node11-benchmark CircleCI is running your tests
Details
ci/circleci: test-node11-functional CircleCI is running your tests
Details
ci/circleci: test-node11-integration-0 CircleCI is running your tests
Details
ci/circleci: test-node11-integration-1 Your tests are queued behind your running builds
Details
ci/circleci: test-node11-unit CircleCI is running your tests
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/api-alias branch May 14, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 14, 2019

The ci/circleci: test-node10-benchmark job is failing as of 4e3de8728cbe28710c5e31f60a2514d192f4f435. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

vasild added a commit that referenced this pull request May 22, 2019

Merge remote-tracking branch 'ArkEcosystem/core/2.6' into nonces-remo…
…ve-incdec

* ArkEcosystem/core/2.6:
  feat: initial nonce implementation (#2573)
  Merge develop into 2.5 (#2600)
  refactor(core-json-rpc): use blockId schema for validation (#2596)
  chore(core-database-postgres): add core-state dependency (#2598)
  fix(core-database-postgres): use day instead of date (#2595)
  refactor: use dayjs as it now has official UTC support (#2592)
  refactor(core-json-rpc): improved version of #2593
  release: 2.3.23 (#2594)
  fix(core-json-rpc): allow use of old and new block IDs (#2593)
  fix(core-p2p): do not suspend peer for `AppNotReady` (#2590)
  chore(changelog): add latest changes for 2.4.0 (#2591)
  chore(ci): setup node.js 12 on CircleCI (#2474)
  fix(core-blockchain): divide blocks into smaller chunks for batch processing (#2586)
  refactor(crypto): fallback to ECDSA signature for version 2 transactions (#2584)
  fix(core-p2p): don't cause suspensions for unresponsive plugins (#2583)
  fix(core-p2p): don't cause suspensions for unresponsive plugins
  test(core-api): set p2p port on dummy peer
  feat(core): command to generate network configuration (#2582)
  fix(core-blockchain): delete bad rounds after unclean shutdown (#2581)
  feat(core-p2p): don't trust headers and verify config and plugin connectivity of peers (#2559)
  refactor: use ApplicationEvents enum instead of string (#2580)
  refactor(core-api): enforce "application/json" as content-type
  refactor(core-api): use pagination configuration limit
  test(e2e): remove version assertions
  chore(ci): update CircleCI configuration
  test(core-tester-cli): update API mock URLs
  refactor(core-api): register /api/v2 as a transition period fallback (#2578)
  test(core-api): use address identity
  refactor(corer-api): remove the legacy API (#2439)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.