Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: reuse steps for different node versions #2644

Merged
merged 10 commits into from Jun 1, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

commented Jun 1, 2019

Reuse steps for different node.js versions instead of relying on a script to duplicate everything.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

faustbrian added some commits Jun 1, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jun 1, 2019

The ci/circleci: node10-integration job is failing as of 0836a0512a3329e72a103494240d792fd8995d54. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian faustbrian marked this pull request as ready for review Jun 1, 2019

@faustbrian faustbrian merged commit 6aa9b2f into develop Jun 1, 2019

15 checks passed

ci/circleci: node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: node10-functional Your tests passed on CircleCI!
Details
ci/circleci: node10-integration Your tests passed on CircleCI!
Details
ci/circleci: node10-unit Your tests passed on CircleCI!
Details
ci/circleci: node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: node11-functional Your tests passed on CircleCI!
Details
ci/circleci: node11-integration Your tests passed on CircleCI!
Details
ci/circleci: node11-unit Your tests passed on CircleCI!
Details
ci/circleci: node12-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node12-e2e Your tests passed on CircleCI!
Details
ci/circleci: node12-functional Your tests passed on CircleCI!
Details
ci/circleci: node12-integration Your tests passed on CircleCI!
Details
ci/circleci: node12-unit Your tests passed on CircleCI!
Details
@codecov-io

This comment has been minimized.

Copy link

commented Jun 1, 2019

Codecov Report

Merging #2644 into develop will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2644      +/-   ##
===========================================
+ Coverage    65.77%   65.78%   +0.01%     
===========================================
  Files          401      401              
  Lines         8771     8772       +1     
  Branches       405      443      +38     
===========================================
+ Hits          5769     5771       +2     
+ Misses        2954     2951       -3     
- Partials        48       50       +2
Impacted Files Coverage Δ
packages/core-database/src/database-service.ts 26.14% <0%> (-0.13%) ⬇️
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️
...es/core-blockchain/src/replay/replay-blockchain.ts 0% <0%> (ø) ⬆️
...e-database-postgres/src/repositories/repository.ts 19.23% <0%> (+3.84%) ⬆️
...ackages/core-database-postgres/src/models/round.ts 85.71% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d20eed1...c32ab05. Read the comment docs.

@ArkEcosystemBot ArkEcosystemBot deleted the test/integration branch Jun 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.