Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(core-api): off by one error in transaction confirmations #2645
It is my understanding that forged transactions must have a positive confirmation count. If that is indeed the case, there is an off-by-one error in the transaction count. This manifests itself by looking at transactions forged in the most recent block, which will show zero confirmations.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
If adding a new feature, the PR's description includes: