Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-p2p): remove redundant p2p port from broadcast #2648

Merged

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

commented Jun 3, 2019

Removes the redundant p2p entry from ports:

image

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

The ci/circleci: node11-integration job is failing as of e9d47b4e9a4864e59be97e6eb011b0b1bc560815. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

The ci/circleci: node10-e2e job is failing as of 69a18331d95a21dec96a55931791d78c0d1880d2. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@supaiku0 supaiku0 force-pushed the supaiku0:refactor/p2p-port-broadcast branch from 6c1f7e2 to caf620d Jun 3, 2019

supaiku0 added some commits Jun 3, 2019

@supaiku0 supaiku0 force-pushed the supaiku0:refactor/p2p-port-broadcast branch from da19276 to f22ad3c Jun 3, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jun 3, 2019

Codecov Report

Merging #2648 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #2648      +/-   ##
==========================================
+ Coverage    65.78%   65.8%   +0.01%     
==========================================
  Files          401     401              
  Lines         8772    8776       +4     
  Branches       443     443              
==========================================
+ Hits          5771    5775       +4     
  Misses        2951    2951              
  Partials        50      50
Impacted Files Coverage Δ
...kages/core-api/src/versions/1/peers/transformer.ts 100% <100%> (ø) ⬆️
packages/core-p2p/src/peer.ts 100% <100%> (ø) ⬆️
...kages/core-api/src/versions/2/peers/transformer.ts 80% <100%> (+13.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34c1424...f22ad3c. Read the comment docs.

@faustbrian faustbrian merged commit 0d63050 into ArkEcosystem:develop Jun 3, 2019

15 checks passed

ci/circleci: node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: node10-functional Your tests passed on CircleCI!
Details
ci/circleci: node10-integration Your tests passed on CircleCI!
Details
ci/circleci: node10-unit Your tests passed on CircleCI!
Details
ci/circleci: node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: node11-functional Your tests passed on CircleCI!
Details
ci/circleci: node11-integration Your tests passed on CircleCI!
Details
ci/circleci: node11-unit Your tests passed on CircleCI!
Details
ci/circleci: node12-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node12-e2e Your tests passed on CircleCI!
Details
ci/circleci: node12-functional Your tests passed on CircleCI!
Details
ci/circleci: node12-integration Your tests passed on CircleCI!
Details
ci/circleci: node12-unit Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.