Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-p2p): improve logging #2652

Merged
merged 4 commits into from Jun 4, 2019

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

commented Jun 4, 2019

This PR removes misleading output like this:

7|ark-relay  | [2019-06-03 23:50:17.705] WARN : The payload contains invalid transaction.
7|ark-relay  | [2019-06-03 23:50:17.712] WARN : The payload contains invalid transaction.
7|ark-relay  | [2019-06-03 23:50:17.730] WARN : The payload contains invalid transaction.
7|ark-relay  | [2019-06-03 23:50:17.737] WARN : The payload contains invalid transaction.
7|ark-relay  | [2019-06-03 23:50:17.740] WARN : The payload contains invalid transaction.
7|ark-relay  | [2019-06-03 23:50:17.767] WARN : The payload contains invalid transaction.
7|ark-relay  | [2019-06-03 23:50:17.771] WARN : The payload contains invalid transaction.
7|ark-relay  | [2019-06-03 23:50:17.803] WARN : The payload contains invalid transaction.
7|ark-relay  | [2019-06-03 23:50:17.825] WARN : The payload contains invalid transaction.
7|ark-relay  | [2019-06-03 23:50:17.832] WARN : The payload contains invalid transaction.

which turns out to be it's own response to a request:

7|ark-rela |   '2adad284d745fd82f8b5cd969245848c235cd8fdf6885b80ef84f1fcf3c9d34c': [ { type: 'ERR_DUPLICATE', message: 'Already in cache.' } ],
7|ark-rela |   '38491bd8a50555fc8316eb1946da6ff2227a70b2f6111784c4cba1ba3b6e627c': [ { type: 'ERR_DUPLICATE', message: 'Already in cache.' } ],
7|ark-rela |   '54223420762c80670a22d81c14b89bcc6e72c5308497994ef2e4e4c00c0c72c4': [ { type: 'ERR_DUPLICATE', message: 'Already in cache.' } ] }
7|ark-rela | { '0e29c123591dbca4039bcb3e69131027857531b54b0aab5b5f517c7d5b592f41': [ { type: 'ERR_DUPLICATE', message: 'Already in cache.' } ],
7|ark-rela |   '58c7dbbe87c3dcbd4d9b30ebd0af26e1cbf1be7fcfc1d96ea40cc68018436e03': [ { type: 'ERR_DUPLICATE', message: 'Already in cache.' } ],
7|ark-rela |   edfd0a7597bf1c3e20fbf3bc5031dadef73f16ce5cdcd4b5b870dba03e5106a6: [ { type: 'ERR_DUPLICATE', message: 'Already in cache.' } ],
7|ark-rela |   b8d647a32167f81e31bccd66e903793484667ece7dfef4361f85ca492e8cfd22: [ { type: 'ERR_DUPLICATE', message: 'Already in cache.' } ],
7|ark-rela |   '9deba453f7386137cc1a40865af9953bd3a56cbad7027eedd4592de1037016a3': [ { type: 'ERR_DUPLICATE', message: 'Already in cache.' } ],
7|ark-rela |   '76a890c25e0e6cb721076993f534456aecb7bdfbe66d1247f83e51bb88f49a6e': [ { type: 'ERR_DUPLICATE', message: 'Already in cache.' } ],
7|ark-rela |   '04d613f5db8d8a2f829cb791995d40b21ded5f54406eb763dabef1e63a429134': [ { type: 'ERR_DUPLICATE', message: 'Already in cache.' } ],
7|ark-rela |   '385473abf7267c75dfd9cb3f74c7f6688aaa15fd74f33ec561075462283d18bf': [ { type: 'ERR_DUPLICATE', message: 'Already in cache.' } ],

Now only genuine errors are logged.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@codecov-io

This comment has been minimized.

Copy link

commented Jun 4, 2019

Codecov Report

Merging #2652 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2652      +/-   ##
===========================================
- Coverage     65.8%   65.79%   -0.01%     
===========================================
  Files          401      401              
  Lines         8776     8777       +1     
  Branches       443      443              
===========================================
  Hits          5775     5775              
- Misses        2951     2952       +1     
  Partials        50       50
Impacted Files Coverage Δ
packages/core-forger/src/manager.ts 53.68% <0%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6c136c...79fab5e. Read the comment docs.

@faustbrian faustbrian merged commit b00e107 into ArkEcosystem:develop Jun 4, 2019

15 checks passed

ci/circleci: node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: node10-functional Your tests passed on CircleCI!
Details
ci/circleci: node10-integration Your tests passed on CircleCI!
Details
ci/circleci: node10-unit Your tests passed on CircleCI!
Details
ci/circleci: node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: node11-functional Your tests passed on CircleCI!
Details
ci/circleci: node11-integration Your tests passed on CircleCI!
Details
ci/circleci: node11-unit Your tests passed on CircleCI!
Details
ci/circleci: node12-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node12-e2e Your tests passed on CircleCI!
Details
ci/circleci: node12-functional Your tests passed on CircleCI!
Details
ci/circleci: node12-integration Your tests passed on CircleCI!
Details
ci/circleci: node12-unit Your tests passed on CircleCI!
Details

vasild added a commit that referenced this pull request Jun 4, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into fix-sna…
…pshot-rounds-dup

* ArkEcosystem/core/develop:
  fix(core-api): invalid orderBy causes internal server error (#2653)
  fix(core): set the correct channel if core was directly installed with @next (#2646)
  refactor(core-p2p): improve logging (#2652)
  misc(core-snapshots): fix the link to the documentation (#2650)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.