Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-api): invalid orderBy causes internal server error #2653

Merged
merged 3 commits into from Jun 4, 2019

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

commented Jun 4, 2019

Resolves #2649

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@supaiku0 supaiku0 force-pushed the fix/api-order-by-transactions branch from d273f58 to 812002b Jun 4, 2019

@supaiku0 supaiku0 force-pushed the fix/api-order-by-transactions branch from 812002b to bfac0c2 Jun 4, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jun 4, 2019

Codecov Report

Merging #2653 into develop will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2653      +/-   ##
===========================================
- Coverage    65.77%   65.76%   -0.01%     
===========================================
  Files          401      401              
  Lines         8780     8781       +1     
  Branches       444      444              
===========================================
  Hits          5775     5775              
- Misses        2955     2956       +1     
  Partials        50       50
Impacted Files Coverage Δ
packages/core-api/src/repositories/transactions.ts 82.64% <66.66%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b431e4...e80fd6a. Read the comment docs.

faustbrian added some commits Jun 4, 2019

@faustbrian faustbrian merged commit 2578376 into develop Jun 4, 2019

15 checks passed

ci/circleci: node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: node10-functional Your tests passed on CircleCI!
Details
ci/circleci: node10-integration Your tests passed on CircleCI!
Details
ci/circleci: node10-unit Your tests passed on CircleCI!
Details
ci/circleci: node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: node11-functional Your tests passed on CircleCI!
Details
ci/circleci: node11-integration Your tests passed on CircleCI!
Details
ci/circleci: node11-unit Your tests passed on CircleCI!
Details
ci/circleci: node12-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node12-e2e Your tests passed on CircleCI!
Details
ci/circleci: node12-functional Your tests passed on CircleCI!
Details
ci/circleci: node12-integration Your tests passed on CircleCI!
Details
ci/circleci: node12-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/api-order-by-transactions branch Jun 4, 2019

vasild added a commit that referenced this pull request Jun 4, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into fix-sna…
…pshot-rounds-dup

* ArkEcosystem/core/develop:
  fix(core-api): invalid orderBy causes internal server error (#2653)
  fix(core): set the correct channel if core was directly installed with @next (#2646)
  refactor(core-p2p): improve logging (#2652)
  misc(core-snapshots): fix the link to the documentation (#2650)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.