Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support updates via git #2654

Draft
wants to merge 10 commits into
base: develop
from

Conversation

Projects
None yet
5 participants
@faustbrian
Copy link
Collaborator

commented Jun 4, 2019

Resolves #2647

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

faustbrian added some commits Jun 4, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jun 4, 2019

Codecov Report

Merging #2654 into develop will decrease coverage by 0.14%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2654      +/-   ##
===========================================
- Coverage    64.76%   64.61%   -0.15%     
===========================================
  Files          362      362              
  Lines         8170     8188      +18     
  Branches       416      382      -34     
===========================================
  Hits          5291     5291              
- Misses        2842     2864      +22     
+ Partials        37       33       -4
Impacted Files Coverage Δ
packages/core/src/helpers/config.ts 0% <ø> (ø) ⬆️
packages/core/src/commands/update.ts 0% <0%> (ø) ⬆️
packages/core/src/helpers/update.ts 0% <0%> (ø) ⬆️
packages/core/src/commands/config/cli.ts 0% <0%> (ø) ⬆️
packages/core-api/src/handlers/utils.ts 77.27% <0%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️
...es/core-blockchain/src/replay/replay-blockchain.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e55dff...0574680. Read the comment docs.

.exec(() => cli.action.start("Pulling latest changes"))
.pull((err, update) => {
if (err) {
this.error(err.message);

This comment has been minimized.

Copy link
@vasild

vasild Jun 4, 2019

Contributor

Maybe the execution should be cancelled here.

}

if (update && update.summary.changes) {
shellSync("cd ../../ && yarn setup");

This comment has been minimized.

Copy link
@vasild

vasild Jun 4, 2019

Contributor

yarn --cwd ../.. setup

Show resolved Hide resolved packages/core/src/commands/update.ts Outdated

faustbrian and others added some commits Jun 4, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

The ci/circleci: node10-functional job is failing as of 60f27112ff1191f1c88dfdc81d76c29e74dc82c1. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

faustbrian added some commits Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.