Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-p2p): perform `acceptNewPeer` non-blocking #2656

Merged
merged 1 commit into from Jun 4, 2019

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

commented Jun 4, 2019

We already fixed this with 2.3, but it somehow regressed with the switch to websockets. Blocking on acceptNewPeer causes issues for nodes running behind a firewall, since they don't respond to pings and therefore trigger a timeout.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@codecov-io

This comment has been minimized.

Copy link

commented Jun 4, 2019

Codecov Report

Merging #2656 into develop will decrease coverage by 0.19%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #2656     +/-   ##
==========================================
- Coverage    65.78%   65.58%   -0.2%     
==========================================
  Files          401      417     +16     
  Lines         8779     8910    +131     
  Branches       406      409      +3     
==========================================
+ Hits          5775     5844     +69     
- Misses        2956     3016     +60     
- Partials        48       50      +2
Impacted Files Coverage Δ
packages/core-p2p/src/socket-server/worker.ts 30.64% <0%> (ø) ⬆️
...s/core-interfaces/src/core-database/event-types.ts 0% <0%> (ø)
packages/core-transaction-pool/src/plugin.ts 100% <0%> (ø)
...aces/src/core-database/search/search-parameters.ts 0% <0%> (ø)
packages/core-blockchain/src/plugin.ts 0% <0%> (ø)
packages/core-wallet-api/src/plugin.ts 0% <0%> (ø)
packages/core-logger-winston/src/plugin.ts 75% <0%> (ø)
packages/core-logger-pino/src/plugin.ts 75% <0%> (ø)
packages/core-p2p/src/plugin.ts 68% <0%> (ø)
packages/core-logger/src/plugin.ts 66.66% <0%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 301790e...52bc9ad. Read the comment docs.

@faustbrian faustbrian merged commit 122254b into develop Jun 4, 2019

15 checks passed

ci/circleci: node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: node10-functional Your tests passed on CircleCI!
Details
ci/circleci: node10-integration Your tests passed on CircleCI!
Details
ci/circleci: node10-unit Your tests passed on CircleCI!
Details
ci/circleci: node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: node11-functional Your tests passed on CircleCI!
Details
ci/circleci: node11-integration Your tests passed on CircleCI!
Details
ci/circleci: node11-unit Your tests passed on CircleCI!
Details
ci/circleci: node12-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node12-e2e Your tests passed on CircleCI!
Details
ci/circleci: node12-functional Your tests passed on CircleCI!
Details
ci/circleci: node12-integration Your tests passed on CircleCI!
Details
ci/circleci: node12-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/non-blocking-acceptNewPeer branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.