Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-container): handle failing optional plugins gracefully #2657

Merged
merged 5 commits into from Jun 5, 2019

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

commented Jun 4, 2019

Introduces the concept of required and optional plugins. When a required plugin throws an error during boot, Core will shutdown like before. But if an optional plugin cannot be loaded it will no longer shutdown and print a nice warning with the error instead.

Unless explicitely marked required, all plugins are considered optional.

The required plugins are:

@arkecosystem/core-event-emitter
@arkecosystem/core-logger-pino
@arkecosystem/core-state
@arkecosystem/core-database-postgres
@arkecosystem/core-transaction-pool
@arkecosystem/core-p2p
@arkecosystem/core-blockchain

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@codecov-io

This comment has been minimized.

Copy link

commented Jun 4, 2019

Codecov Report

Merging #2657 into develop will decrease coverage by 0.05%.
The diff coverage is 42.1%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2657      +/-   ##
===========================================
- Coverage    65.76%   65.71%   -0.06%     
===========================================
  Files          401      401              
  Lines         8781     8791      +10     
  Branches       444      406      -38     
===========================================
+ Hits          5775     5777       +2     
- Misses        2956     2966      +10     
+ Partials        50       48       -2
Impacted Files Coverage Δ
packages/core-container/src/registrars/plugin.ts 63.33% <42.1%> (-8.67%) ⬇️
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️
...es/core-blockchain/src/replay/replay-blockchain.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f32b8...5a423b4. Read the comment docs.

supaiku0 added some commits Jun 4, 2019

@faustbrian faustbrian merged commit 5fbf8b6 into develop Jun 5, 2019

15 checks passed

ci/circleci: node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: node10-functional Your tests passed on CircleCI!
Details
ci/circleci: node10-integration Your tests passed on CircleCI!
Details
ci/circleci: node10-unit Your tests passed on CircleCI!
Details
ci/circleci: node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: node11-functional Your tests passed on CircleCI!
Details
ci/circleci: node11-integration Your tests passed on CircleCI!
Details
ci/circleci: node11-unit Your tests passed on CircleCI!
Details
ci/circleci: node12-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node12-e2e Your tests passed on CircleCI!
Details
ci/circleci: node12-functional Your tests passed on CircleCI!
Details
ci/circleci: node12-integration Your tests passed on CircleCI!
Details
ci/circleci: node12-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/ignore-missing-optional-plugins branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.