Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-container): handle failing optional plugins gracefully #2657

Merged
merged 5 commits into from Jun 5, 2019
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

misc: wording

  • Loading branch information...
supaiku0 committed Jun 4, 2019
commit b06990b2a574cb7ec7af69b0ed77643b70ebfb0e
@@ -129,7 +129,7 @@ export class PluginRegistrar {
}
} catch (error) {
if (item.plugin.required) {
this.container.forceExit(`Failed to register required plugin '${name}'`, error);
this.container.forceExit(`Failed to load required plugin '${name}'`, error);
} else {
this.failedPlugins[name] = error;
}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.