Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core-transaction-pool): add more tests for `getTransactionsForForging` #2659

Merged
merged 38 commits into from Jun 5, 2019

Conversation

Projects
None yet
6 participants
@supaiku0
Copy link
Contributor

commented Jun 5, 2019

A summary of what changes this PR introduces and why they were made.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

air1one and others added some commits May 29, 2019

fix(core-transaction-pool): remove already forged transactions before…
… forging

Signed-off-by: supaiku <supaiku@protonmail.com>
@codecov-io

This comment has been minimized.

Copy link

commented Jun 5, 2019

Codecov Report

Merging #2659 into develop will increase coverage by 0.03%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #2659      +/-   ##
==========================================
+ Coverage    65.76%   65.8%   +0.03%     
==========================================
  Files          401     401              
  Lines         8781    8788       +7     
  Branches       444     444              
==========================================
+ Hits          5775    5783       +8     
+ Misses        2956    2955       -1     
  Partials        50      50
Impacted Files Coverage Δ
packages/crypto/src/transactions/deserializer.ts 89.04% <0%> (-1.24%) ⬇️
packages/core-transaction-pool/src/connection.ts 96.06% <100%> (+1.29%) ⬆️
...es/core-p2p/src/socket-server/versions/internal.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f32b8...a6021dd. Read the comment docs.

@codecov-io

This comment has been minimized.

Copy link

commented Jun 5, 2019

Codecov Report

Merging #2659 into develop will increase coverage by 0.05%.
The diff coverage is 95.83%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2659      +/-   ##
===========================================
+ Coverage    65.71%   65.76%   +0.05%     
===========================================
  Files          401      401              
  Lines         8791     8801      +10     
  Branches       444      406      -38     
===========================================
+ Hits          5777     5788      +11     
- Misses        2964     2965       +1     
+ Partials        50       48       -2
Impacted Files Coverage Δ
packages/crypto/src/transactions/deserializer.ts 89.04% <0%> (-1.24%) ⬇️
packages/core-transaction-pool/src/connection.ts 96.13% <100%> (+1.36%) ⬆️
...es/core-p2p/src/socket-server/versions/internal.ts 100% <100%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️
...es/core-blockchain/src/replay/replay-blockchain.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fbf8b6...03c82f0. Read the comment docs.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

The ci/circleci: node10-integration job is failing as of d6091b4b7c46ef84dce36bd27a3158b226cd9739. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian faustbrian merged commit ceee129 into develop Jun 5, 2019

15 checks passed

ci/circleci: node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: node10-functional Your tests passed on CircleCI!
Details
ci/circleci: node10-integration Your tests passed on CircleCI!
Details
ci/circleci: node10-unit Your tests passed on CircleCI!
Details
ci/circleci: node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: node11-functional Your tests passed on CircleCI!
Details
ci/circleci: node11-integration Your tests passed on CircleCI!
Details
ci/circleci: node11-unit Your tests passed on CircleCI!
Details
ci/circleci: node12-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node12-e2e Your tests passed on CircleCI!
Details
ci/circleci: node12-functional Your tests passed on CircleCI!
Details
ci/circleci: node12-integration Your tests passed on CircleCI!
Details
ci/circleci: node12-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the test/tx-pool-getTransactionsForForging branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.