Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core-snapshots): don't append duplicate rounds rows to a snapshot #2662

Merged
merged 3 commits into from Jun 5, 2019
Merged

fix(core-snapshots): don't append duplicate rounds rows to a snapshot #2662

merged 3 commits into from Jun 5, 2019

Commits on Jun 5, 2019

  1. fix(core-snapshots): don't append duplicate rounds rows to a snapshot 

    When appending to an existent snapshot, only append rows with higher id
than already in the (old) snapshot. Otherwise the snapshot would contain
rows with duplciate rounds.id values and would not be importable.

This patch assumes no gaps in rounds.id and monotonically increasing
rounds.id when new rounds are being added.
    @vasild
    vasild committed Jun 5, 2019
    Copy the full SHA
    80e9367 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into fix/dont-append-duplicate-rounds-rows

    @faustbrian
    faustbrian committed Jun 5, 2019
    Copy the full SHA
    2ac8a6d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into fix/dont-append-duplicate-rounds-rows

    @faustbrian
    faustbrian committed Jun 5, 2019
    Copy the full SHA
    f25da90 View commit details
    Browse the repository at this point in the history