Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 2.4.0 #2668

Merged
merged 235 commits into from Jun 12, 2019

Conversation

Projects
None yet
@faustbrian
Copy link
Collaborator

commented Jun 6, 2019

Release 2.4.0 stable for mainnet.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

https://docs.ark.io/releases/v2.4/migrating_2.3_2.4.html#upgrade-steps

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

air1one and others added some commits Apr 2, 2019

@air1one

This comment was marked as resolved.

Copy link
Collaborator

commented on packages/core-p2p/src/socket-server/worker.ts in 37ea8a3 Apr 9, 2019

You can't do req.socket in handshake because underlying socket doesn't exist yet, just return next(new Error(...)) like below.
(https://socketcluster.io/#!/docs/middleware-and-authorization)

air1one and others added some commits Apr 9, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jun 6, 2019

Codecov Report

Merging #2668 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2668      +/-   ##
=========================================
- Coverage   66.01%   65.9%   -0.12%     
=========================================
  Files         400     401       +1     
  Lines        8616    8837     +221     
  Branches      436     412      -24     
=========================================
+ Hits         5688    5824     +136     
- Misses       2883    2965      +82     
- Partials       45      48       +3
Impacted Files Coverage Δ
packages/core-forger/src/errors.ts 33.33% <0%> (-55.56%) ⬇️
packages/core-blockchain/src/blockchain.ts 58.94% <0%> (-30.54%) ⬇️
...ges/core-database-postgres/src/models/migration.ts 75% <0%> (-25%) ⬇️
packages/core-forger/src/client.ts 62.79% <0%> (-24.06%) ⬇️
...core-transactions/src/handlers/second-signature.ts 68.42% <0%> (-21.58%) ⬇️
...ackages/core-api/src/versions/2/node/controller.ts 53.12% <0%> (-19.61%) ⬇️
...ackages/core-database-postgres/src/models/model.ts 57.14% <0%> (-17.86%) ⬇️
...ain/src/processor/handlers/accept-block-handler.ts 85% <0%> (-15%) ⬇️
...ase/src/repositories/blocks-business-repository.ts 66.66% <0%> (-14.59%) ⬇️
packages/core-p2p/src/errors.ts 76.92% <0%> (-13.99%) ⬇️
... and 342 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 305bc48...b353720. Read the comment docs.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

The ci/circleci: node11-e2e job is failing as of 1bb6e9317cdec6937772a16fec20e8e98f4433bc. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

supaiku0 and others added some commits Jun 8, 2019

refactor(core-transaction-pool): expire transactions that don't have … (
#2672)

* refactor(core-transaction-pool): expire transactions that don't have expiration

If a transaction does not have an expiration value set by the user, then
we would keep it for a long time in the pool and also it could possibly
be re-sent by somebody (not the author) long time after it was created,
if it has not been forged yet.

Change this to expire after 6h even transactions that don't have an
user-set expiration. 6h considered since the transaction creation time.

* Ignore the expiration of v1 transactions

* Rename some variables and a method

* Properly call the Memory constructor from tests

* test(core-transaction-pool): adjust expiration test

* chore(core-transaction-pool): silence tslint

* test(core-blockchain): disable transactions expiration

Since we try to apply the genesis transactions, which are created a few
years ago, set the pool default expiration to some point in the distant
future.

@faustbrian faustbrian marked this pull request as ready for review Jun 12, 2019

@faustbrian faustbrian requested review from kristjank and supaiku0 as code owners Jun 12, 2019

@faustbrian faustbrian merged commit 1cbc2a0 into master Jun 12, 2019

15 checks passed

ci/circleci: node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: node10-functional Your tests passed on CircleCI!
Details
ci/circleci: node10-integration Your tests passed on CircleCI!
Details
ci/circleci: node10-unit Your tests passed on CircleCI!
Details
ci/circleci: node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: node11-functional Your tests passed on CircleCI!
Details
ci/circleci: node11-integration Your tests passed on CircleCI!
Details
ci/circleci: node11-unit Your tests passed on CircleCI!
Details
ci/circleci: node12-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node12-e2e Your tests passed on CircleCI!
Details
ci/circleci: node12-functional Your tests passed on CircleCI!
Details
ci/circleci: node12-integration Your tests passed on CircleCI!
Details
ci/circleci: node12-unit Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.