Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-api): missing block confirmations on v2 endpoint #2674

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

commented Jun 8, 2019

Only the v1 endpoint displayed them.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@codecov-io

This comment has been minimized.

Copy link

commented Jun 8, 2019

Codecov Report

Merging #2674 into develop will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #2674      +/-   ##
==========================================
- Coverage     65.8%   65.8%   -0.01%     
==========================================
  Files          401     401              
  Lines         8820    8822       +2     
  Branches       410     411       +1     
==========================================
+ Hits          5804    5805       +1     
  Misses        2968    2968              
- Partials        48      49       +1
Impacted Files Coverage Δ
...ages/core-api/src/versions/2/blocks/transformer.ts 90.9% <50%> (-9.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bb6e93...d244083. Read the comment docs.

@faustbrian faustbrian merged commit 145135b into ArkEcosystem:develop Jun 8, 2019

15 checks passed

ci/circleci: node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: node10-functional Your tests passed on CircleCI!
Details
ci/circleci: node10-integration Your tests passed on CircleCI!
Details
ci/circleci: node10-unit Your tests passed on CircleCI!
Details
ci/circleci: node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: node11-functional Your tests passed on CircleCI!
Details
ci/circleci: node11-integration Your tests passed on CircleCI!
Details
ci/circleci: node11-unit Your tests passed on CircleCI!
Details
ci/circleci: node12-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node12-e2e Your tests passed on CircleCI!
Details
ci/circleci: node12-functional Your tests passed on CircleCI!
Details
ci/circleci: node12-integration Your tests passed on CircleCI!
Details
ci/circleci: node12-unit Your tests passed on CircleCI!
Details

vasild added a commit that referenced this pull request Jun 10, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into tx-expi…
…ration

* ArkEcosystem/core/develop:
  fix(core-api): missing block confirmations on v2 endpoint (#2674)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.