Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(crypto): move base58 functions to utils #2675

Merged
merged 3 commits into from Jun 8, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

commented Jun 8, 2019

Move the base58 specific code out of the address identity because identities shouldn't expose anything besides methods to generate/validate the type of identity it is.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@codecov-io

This comment has been minimized.

Copy link

commented Jun 8, 2019

Codecov Report

Merging #2675 into 2.6 will decrease coverage by 0.01%.
The diff coverage is 84.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.6    #2675      +/-   ##
==========================================
- Coverage   64.88%   64.86%   -0.02%     
==========================================
  Files         362      363       +1     
  Lines        8201     8203       +2     
  Branches      418      382      -36     
==========================================
  Hits         5321     5321              
- Misses       2841     2847       +6     
+ Partials       39       35       -4
Impacted Files Coverage Δ
packages/crypto/src/identities/address.ts 100% <100%> (ø) ⬆️
packages/crypto/src/transactions/types/transfer.ts 100% <100%> (ø) ⬆️
packages/crypto/src/transactions/serializer.ts 89.25% <100%> (+0.08%) ⬆️
packages/crypto/src/utils/base58.ts 100% <100%> (ø)
packages/crypto/src/crypto/bip38.ts 96.49% <100%> (-0.86%) ⬇️
...crypto/src/transactions/types/timelock-transfer.ts 40% <33.33%> (-2.86%) ⬇️
packages/core-transactions/src/utils.ts 66.66% <50%> (ø) ⬆️
...ges/crypto/src/transactions/types/multi-payment.ts 38.09% <50%> (-2.82%) ⬇️
packages/core-api/src/formats.ts 44.44% <50%> (ø) ⬆️
packages/crypto/src/errors.ts 81.63% <0%> (-2.05%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50ded58...6789513. Read the comment docs.

faustbrian added some commits Jun 8, 2019

@faustbrian faustbrian merged commit c70b6fb into 2.6 Jun 8, 2019

15 checks passed

ci/circleci: node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: node10-functional Your tests passed on CircleCI!
Details
ci/circleci: node10-integration Your tests passed on CircleCI!
Details
ci/circleci: node10-unit Your tests passed on CircleCI!
Details
ci/circleci: node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: node11-functional Your tests passed on CircleCI!
Details
ci/circleci: node11-integration Your tests passed on CircleCI!
Details
ci/circleci: node11-unit Your tests passed on CircleCI!
Details
ci/circleci: node12-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node12-e2e Your tests passed on CircleCI!
Details
ci/circleci: node12-functional Your tests passed on CircleCI!
Details
ci/circleci: node12-integration Your tests passed on CircleCI!
Details
ci/circleci: node12-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the 26/b58 branch Jun 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.