Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-p2p): check claimed state of peer #2686

Merged
merged 10 commits into from Jun 12, 2019

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

commented Jun 12, 2019

The peer verifier now also checks the claimed height and block header for validity.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

supaiku0 and others added some commits Jun 11, 2019

misc(core-p2p): Only log a single "success" on peer verification
Also:
* Rename verifyStateHeader() to checkStateHeader(), so that it is
  consistent with checkState()
* Some rewording of log messages for clarity

faustbrian added some commits Jun 12, 2019

@faustbrian faustbrian merged commit 867c334 into develop Jun 12, 2019

0 of 15 checks passed

ci/circleci: node10-benchmark Your tests are queued behind your running builds
Details
ci/circleci: node10-e2e Your tests are queued behind your running builds
Details
ci/circleci: node10-functional Your tests are queued behind your running builds
Details
ci/circleci: node10-integration Your tests are queued behind your running builds
Details
ci/circleci: node10-unit Your tests are queued behind your running builds
Details
ci/circleci: node11-benchmark Your tests are queued behind your running builds
Details
ci/circleci: node11-e2e Your tests are queued behind your running builds
Details
ci/circleci: node11-functional Your tests are queued behind your running builds
Details
ci/circleci: node11-integration Your tests are queued behind your running builds
Details
ci/circleci: node11-unit Your tests are queued behind your running builds
Details
ci/circleci: node12-benchmark Your tests are queued behind your running builds
Details
ci/circleci: node12-e2e Your tests are queued behind your running builds
Details
ci/circleci: node12-functional Your tests are queued behind your running builds
Details
ci/circleci: node12-integration Your tests are queued behind your running builds
Details
ci/circleci: node12-unit Your tests are queued behind your running builds
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/core-p2p/claimed-state-check branch Jun 12, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

The ci/circleci: node12-e2e job is failing as of 314ddedfc5626a0668b37b842ea4ce3b9ae4064c. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@supaiku0 supaiku0 referenced this pull request Jun 18, 2019

Merged

perf(core-p2p): improve peer block header check #2719

1 of 18 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.