Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-forger): ignore overheight block #2687

Merged
merged 2 commits into from Jun 12, 2019

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

commented Jun 12, 2019

Keep forging even if overheight block is detected.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

alessiodf and others added some commits Jun 9, 2019

@faustbrian faustbrian merged commit 72dc441 into develop Jun 12, 2019

0 of 15 checks passed

ci/circleci: node10-benchmark Your tests are queued behind your running builds
Details
ci/circleci: node10-e2e Your tests are queued behind your running builds
Details
ci/circleci: node10-functional Your tests are queued behind your running builds
Details
ci/circleci: node10-integration Your tests are queued behind your running builds
Details
ci/circleci: node10-unit Your tests are queued behind your running builds
Details
ci/circleci: node11-benchmark Your tests are queued behind your running builds
Details
ci/circleci: node11-e2e Your tests are queued behind your running builds
Details
ci/circleci: node11-functional Your tests are queued behind your running builds
Details
ci/circleci: node11-integration Your tests are queued behind your running builds
Details
ci/circleci: node11-unit Your tests are queued behind your running builds
Details
ci/circleci: node12-benchmark Your tests are queued behind your running builds
Details
ci/circleci: node12-e2e Your tests are queued behind your running builds
Details
ci/circleci: node12-functional CircleCI is running your tests
Details
ci/circleci: node12-integration Your tests are queued behind your running builds
Details
ci/circleci: node12-unit CircleCI is running your tests
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/overheight-header branch Jun 12, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

The ci/circleci: node10-functional job is failing as of 8b26df8cf9da77c33e17ef18ea98fa7ca10c3297. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.