Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crypto): reject future and expired transaction timestamps #2757

Merged
merged 10 commits into from Jul 2, 2019

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

commented Jun 27, 2019

Reject transactions where the timestamp is older than 6 hours or from the future to be more in line with the pool.

A new milestone is introduced just for ARK mainnet (height: 9000000) and devnet (height: 2850000) to stop accepting expired/future transaction timestamps.

The alternative would have been be to add 7000+ mainnet exceptions respectively 1400+ devnet exceptions.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@supaiku0 supaiku0 force-pushed the fix/crypto/timestamp-check branch from 11245b0 to 8f86ec3 Jun 27, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

The ci/circleci: node12-functional job is failing as of 8f86ec32affb51174220a19edf2236bda58cf70a. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

faustbrian added some commits Jun 27, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jun 27, 2019

Codecov Report

Merging #2757 into develop will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2757      +/-   ##
===========================================
- Coverage    65.36%   65.34%   -0.02%     
===========================================
  Files          363      363              
  Lines         8115     8118       +3     
  Branches       422      386      -36     
===========================================
+ Hits          5304     5305       +1     
- Misses        2773     2779       +6     
+ Partials        38       34       -4
Impacted Files Coverage Δ
packages/crypto/src/blocks/block.ts 87.75% <33.33%> (-1.72%) ⬇️
packages/core-api/src/handlers/utils.ts 77.27% <0%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️
...es/core-blockchain/src/replay/replay-blockchain.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b1e64f...b49f275. Read the comment docs.

faustbrian and others added some commits Jun 28, 2019

@faustbrian faustbrian merged commit f163023 into develop Jul 2, 2019

15 checks passed

ci/circleci: node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: node10-functional Your tests passed on CircleCI!
Details
ci/circleci: node10-integration Your tests passed on CircleCI!
Details
ci/circleci: node10-unit Your tests passed on CircleCI!
Details
ci/circleci: node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: node11-functional Your tests passed on CircleCI!
Details
ci/circleci: node11-integration Your tests passed on CircleCI!
Details
ci/circleci: node11-unit Your tests passed on CircleCI!
Details
ci/circleci: node12-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node12-e2e Your tests passed on CircleCI!
Details
ci/circleci: node12-functional Your tests passed on CircleCI!
Details
ci/circleci: node12-integration Your tests passed on CircleCI!
Details
ci/circleci: node12-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/crypto/timestamp-check branch Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.