Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependencies to latest versions #2768

Merged
merged 8 commits into from Jul 5, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

commented Jul 2, 2019

This includes a major version bump of bcrypto which includes a lot of performance and schnorr improvements.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

The ci/circleci: node11-functional job is failing as of 8d6e62d301dcbad31b537b6c71308fe1a45ec6c5. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

faustbrian and others added some commits Jul 2, 2019

@faustbrian faustbrian marked this pull request as ready for review Jul 4, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jul 4, 2019

Codecov Report

Merging #2768 into develop will not change coverage.
The diff coverage is 63.63%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2768   +/-   ##
========================================
  Coverage    65.37%   65.37%           
========================================
  Files          363      363           
  Lines         8152     8152           
  Branches       423      387   -36     
========================================
  Hits          5329     5329           
- Misses        2785     2789    +4     
+ Partials        38       34    -4
Impacted Files Coverage Δ
packages/core/src/commands/top.ts 0% <ø> (ø) ⬆️
packages/core/src/shared/status.ts 0% <ø> (ø) ⬆️
...ckages/core/src/hooks/command_not_found/suggest.ts 0% <ø> (ø) ⬆️
packages/core/src/hooks/init/update.ts 0% <0%> (ø) ⬆️
packages/core/src/helpers/update.ts 0% <0%> (ø) ⬆️
packages/core/src/commands/config/reset.ts 0% <0%> (ø) ⬆️
packages/core-forger/src/manager.ts 52.68% <0%> (ø) ⬆️
packages/core-blockchain/src/blockchain.ts 62.65% <0%> (ø) ⬆️
packages/core-database/src/database-service.ts 24.56% <0%> (ø) ⬆️
packages/core/src/process-manager.ts 0% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7de758b...d9dbd4f. Read the comment docs.

@codecov-io

This comment has been minimized.

Copy link

commented Jul 4, 2019

Codecov Report

Merging #2768 into develop will decrease coverage by 0.23%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2768      +/-   ##
===========================================
- Coverage    65.37%   65.13%   -0.24%     
===========================================
  Files          363      379      +16     
  Lines         8152     8287     +135     
  Branches       423      426       +3     
===========================================
+ Hits          5329     5398      +69     
- Misses        2785     2849      +64     
- Partials        38       40       +2
Impacted Files Coverage Δ
packages/core/src/commands/top.ts 0% <ø> (ø) ⬆️
packages/core/src/shared/status.ts 0% <ø> (ø) ⬆️
...ckages/core/src/hooks/command_not_found/suggest.ts 0% <ø> (ø) ⬆️
packages/core/src/hooks/init/update.ts 0% <0%> (ø) ⬆️
packages/core/src/helpers/update.ts 0% <0%> (ø) ⬆️
packages/core/src/commands/config/reset.ts 0% <0%> (ø) ⬆️
packages/core-forger/src/manager.ts 52.68% <0%> (ø) ⬆️
packages/core-blockchain/src/blockchain.ts 62.65% <0%> (ø) ⬆️
packages/core-database/src/database-service.ts 24.56% <0%> (ø) ⬆️
packages/core/src/process-manager.ts 0% <0%> (ø) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c540ca...3f862c3. Read the comment docs.

@supaiku0 supaiku0 merged commit 43bbb3f into develop Jul 5, 2019

15 checks passed

ci/circleci: node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: node10-functional Your tests passed on CircleCI!
Details
ci/circleci: node10-integration Your tests passed on CircleCI!
Details
ci/circleci: node10-unit Your tests passed on CircleCI!
Details
ci/circleci: node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: node11-functional Your tests passed on CircleCI!
Details
ci/circleci: node11-integration Your tests passed on CircleCI!
Details
ci/circleci: node11-unit Your tests passed on CircleCI!
Details
ci/circleci: node12-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node12-e2e Your tests passed on CircleCI!
Details
ci/circleci: node12-functional Your tests passed on CircleCI!
Details
ci/circleci: node12-integration Your tests passed on CircleCI!
Details
ci/circleci: node12-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the deps branch Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.