Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: some fixes for the deployer #2782

Merged
merged 1 commit into from Jul 9, 2019

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

commented Jul 9, 2019

Backports a fix for core-wallet-api which behaved incorrectly when loaded before core-api and a crash in the /node/fees endpoint when there are no transactions.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@codecov-io

This comment has been minimized.

Copy link

commented Jul 9, 2019

Codecov Report

Merging #2782 into master will decrease coverage by <.01%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2782      +/-   ##
==========================================
- Coverage   65.77%   65.77%   -0.01%     
==========================================
  Files         401      402       +1     
  Lines        8850     8858       +8     
  Branches      452      454       +2     
==========================================
+ Hits         5821     5826       +5     
- Misses       2980     2982       +2     
- Partials       49       50       +1
Impacted Files Coverage Δ
...database-postgres/src/repositories/transactions.ts 23.07% <0%> (ø) ⬆️
packages/core-container/src/registrars/plugin.ts 65.62% <0%> (-3.23%) ⬇️
packages/core-http-utils/src/plugins/whitelist.ts 0% <0%> (ø) ⬆️
packages/core-utils/src/is-whitelisted.ts 71.42% <71.42%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0c2d72...fdaab97. Read the comment docs.

1 similar comment
@codecov-io

This comment has been minimized.

Copy link

commented Jul 9, 2019

Codecov Report

Merging #2782 into master will decrease coverage by <.01%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2782      +/-   ##
==========================================
- Coverage   65.77%   65.77%   -0.01%     
==========================================
  Files         401      402       +1     
  Lines        8850     8858       +8     
  Branches      452      454       +2     
==========================================
+ Hits         5821     5826       +5     
- Misses       2980     2982       +2     
- Partials       49       50       +1
Impacted Files Coverage Δ
...database-postgres/src/repositories/transactions.ts 23.07% <0%> (ø) ⬆️
packages/core-container/src/registrars/plugin.ts 65.62% <0%> (-3.23%) ⬇️
packages/core-http-utils/src/plugins/whitelist.ts 0% <0%> (ø) ⬆️
packages/core-utils/src/is-whitelisted.ts 71.42% <71.42%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0c2d72...fdaab97. Read the comment docs.

@faustbrian faustbrian merged commit 1df3b0e into master Jul 9, 2019

15 checks passed

ci/circleci: node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: node10-functional Your tests passed on CircleCI!
Details
ci/circleci: node10-integration Your tests passed on CircleCI!
Details
ci/circleci: node10-unit Your tests passed on CircleCI!
Details
ci/circleci: node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: node11-functional Your tests passed on CircleCI!
Details
ci/circleci: node11-integration Your tests passed on CircleCI!
Details
ci/circleci: node11-unit Your tests passed on CircleCI!
Details
ci/circleci: node12-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node12-e2e Your tests passed on CircleCI!
Details
ci/circleci: node12-functional Your tests passed on CircleCI!
Details
ci/circleci: node12-integration Your tests passed on CircleCI!
Details
ci/circleci: node12-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/backport-wallet-api-fixes branch Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.