Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-p2p): refresh peer ports #2784

Merged
merged 8 commits into from Jul 10, 2019

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

commented Jul 9, 2019

We used to do it only once and cache the result for the entire lifetime of a peer.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

supaiku0 added some commits Jul 9, 2019

supaiku0 added some commits Jul 9, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jul 9, 2019

Codecov Report

Merging #2784 into develop will increase coverage by 0.04%.
The diff coverage is 63.15%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2784      +/-   ##
===========================================
+ Coverage    65.25%   65.29%   +0.04%     
===========================================
  Files          363      363              
  Lines         8173     8184      +11     
  Branches       426      426              
===========================================
+ Hits          5333     5344      +11     
  Misses        2802     2802              
  Partials        38       38
Impacted Files Coverage Δ
...ckages/core-database-postgres/src/state-builder.ts 10.52% <0%> (ø) ⬆️
packages/core-p2p/src/peer.ts 92.85% <100%> (+0.54%) ⬆️
packages/core-p2p/src/peer-communicator.ts 67.74% <40%> (+2.15%) ⬆️
packages/core-api/src/server.ts 63.15% <50%> (-0.74%) ⬇️
packages/core-p2p/src/network-monitor.ts 68.68% <88.88%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4267236...552952b. Read the comment docs.

supaiku0 and others added some commits Jul 9, 2019

@faustbrian faustbrian merged commit c384625 into develop Jul 10, 2019

15 checks passed

ci/circleci: node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: node10-functional Your tests passed on CircleCI!
Details
ci/circleci: node10-integration Your tests passed on CircleCI!
Details
ci/circleci: node10-unit Your tests passed on CircleCI!
Details
ci/circleci: node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: node11-functional Your tests passed on CircleCI!
Details
ci/circleci: node11-integration Your tests passed on CircleCI!
Details
ci/circleci: node11-unit Your tests passed on CircleCI!
Details
ci/circleci: node12-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node12-e2e Your tests passed on CircleCI!
Details
ci/circleci: node12-functional Your tests passed on CircleCI!
Details
ci/circleci: node12-integration Your tests passed on CircleCI!
Details
ci/circleci: node12-unit Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the fix/core-p2p/port-refresh branch Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.