Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-forger): also check if still in same slot #2792

Merged
merged 5 commits into from Jul 10, 2019

Conversation

Projects
None yet
5 participants
@supaiku0
Copy link
Contributor

commented Jul 10, 2019

A summary of what changes this PR introduces and why they were made.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

supaiku0 added some commits Jul 10, 2019

@vasild
Copy link
Contributor

left a comment

Looks good, just two minor comments. Feel free to ignore them.

Show resolved Hide resolved __tests__/unit/core-forger/manager.test.ts Outdated
Show resolved Hide resolved packages/core-forger/src/manager.ts Outdated
@codecov-io

This comment has been minimized.

Copy link

commented Jul 10, 2019

Codecov Report

Merging #2792 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2792      +/-   ##
===========================================
+ Coverage    65.29%   65.31%   +0.02%     
===========================================
  Files          363      363              
  Lines         8184     8189       +5     
  Branches       426      427       +1     
===========================================
+ Hits          5344     5349       +5     
  Misses        2802     2802              
  Partials        38       38
Impacted Files Coverage Δ
packages/core-forger/src/manager.ts 56.43% <100%> (+2.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dddeaf1...922407e. Read the comment docs.

@faustbrian faustbrian merged commit ec68d39 into develop Jul 10, 2019

0 of 15 checks passed

ci/circleci: node10-benchmark Your tests are queued behind your running builds
Details
ci/circleci: node10-e2e Your tests are queued behind your running builds
Details
ci/circleci: node10-functional Your tests are queued behind your running builds
Details
ci/circleci: node10-integration Your tests are queued behind your running builds
Details
ci/circleci: node10-unit Your tests are queued behind your running builds
Details
ci/circleci: node11-benchmark Your tests are queued behind your running builds
Details
ci/circleci: node11-e2e Your tests are queued behind your running builds
Details
ci/circleci: node11-functional Your tests are queued behind your running builds
Details
ci/circleci: node11-integration Your tests are queued behind your running builds
Details
ci/circleci: node11-unit Your tests are queued behind your running builds
Details
ci/circleci: node12-benchmark Your tests are queued behind your running builds
Details
ci/circleci: node12-e2e Your tests are queued behind your running builds
Details
ci/circleci: node12-functional Your tests are queued behind your running builds
Details
ci/circleci: node12-integration Your tests are queued behind your running builds
Details
ci/circleci: node12-unit Your tests are queued behind your running builds
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/core-forger/slot-timeout branch Jul 10, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

The ci/circleci: node10-e2e job is failing as of d5f2517d3c859022b70b091c608355e1382b79f6. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

The ci/circleci: node12-integration job is failing as of d5f2517d3c859022b70b091c608355e1382b79f6. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

The ci/circleci: node12-benchmark job is failing as of d5f2517d3c859022b70b091c608355e1382b79f6. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

The ci/circleci: node10-functional job is failing as of d5f2517d3c859022b70b091c608355e1382b79f6. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

The ci/circleci: node12-unit job is failing as of d5f2517d3c859022b70b091c608355e1382b79f6. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

The ci/circleci: node10-unit job is failing as of d5f2517d3c859022b70b091c608355e1382b79f6. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

The ci/circleci: node10-integration job is failing as of d5f2517d3c859022b70b091c608355e1382b79f6. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

The ci/circleci: node11-functional job is failing as of d5f2517d3c859022b70b091c608355e1382b79f6. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.