Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-http-utils): loading of ssl certificate #2800

Merged
merged 1 commit into from Jul 11, 2019

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

commented Jul 11, 2019

A summary of what changes this PR introduces and why they were made.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@faustbrian faustbrian merged commit 8f8a078 into master Jul 11, 2019

15 checks passed

ci/circleci: node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: node10-functional Your tests passed on CircleCI!
Details
ci/circleci: node10-integration Your tests passed on CircleCI!
Details
ci/circleci: node10-unit Your tests passed on CircleCI!
Details
ci/circleci: node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: node11-functional Your tests passed on CircleCI!
Details
ci/circleci: node11-integration Your tests passed on CircleCI!
Details
ci/circleci: node11-unit Your tests passed on CircleCI!
Details
ci/circleci: node12-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node12-e2e Your tests passed on CircleCI!
Details
ci/circleci: node12-functional Your tests passed on CircleCI!
Details
ci/circleci: node12-integration Your tests passed on CircleCI!
Details
ci/circleci: node12-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/core-http-utils/ssl branch Jul 11, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jul 11, 2019

Codecov Report

Merging #2800 into master will decrease coverage by 0.22%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2800      +/-   ##
=========================================
- Coverage   65.33%   65.1%   -0.23%     
=========================================
  Files         363     379      +16     
  Lines        8192    8328     +136     
  Branches      391     395       +4     
=========================================
+ Hits         5352    5422      +70     
- Misses       2806    2870      +64     
- Partials       34      36       +2
Impacted Files Coverage Δ
packages/core-http-utils/src/server/create.ts 66.66% <0%> (ø) ⬆️
packages/core-container/src/registrars/plugin.ts 66.15% <50%> (+0.52%) ⬆️
...s/core-interfaces/src/core-database/event-types.ts 0% <0%> (ø)
packages/core-transaction-pool/src/plugin.ts 100% <0%> (ø)
...aces/src/core-database/search/search-parameters.ts 0% <0%> (ø)
packages/core-blockchain/src/plugin.ts 0% <0%> (ø)
packages/core-wallet-api/src/plugin.ts 0% <0%> (ø)
packages/core-logger-winston/src/plugin.ts 75% <0%> (ø)
packages/core-logger-pino/src/plugin.ts 75% <0%> (ø)
packages/core-p2p/src/plugin.ts 70.83% <0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3675ebb...6d6a9d2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.