Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: transaction registry #2859

Merged
merged 3 commits into from Aug 2, 2019

Conversation

@supaiku0
Copy link
Contributor

commented Aug 2, 2019

Allows transaction types to depend on other transaction types which are automatically resolved by the transaction registry. This is especially useful for plugins since they no longer need to worry that their transaction types are registered in the correct order as long as the dependencies are correct.

Also cleans everything a bit up and adds more test coverage needed for an upcoming PR.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@faustbrian faustbrian merged commit 16a15e0 into 2.6 Aug 2, 2019

56 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
ci/circleci: node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node10-functional Your tests passed on CircleCI!
Details
ci/circleci: node10-integration Your tests passed on CircleCI!
Details
ci/circleci: node10-unit Your tests passed on CircleCI!
Details
ci/circleci: node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: node11-functional Your tests passed on CircleCI!
Details
ci/circleci: node11-integration Your tests passed on CircleCI!
Details
ci/circleci: node11-unit Your tests passed on CircleCI!
Details
ci/circleci: node12-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node12-e2e Your tests passed on CircleCI!
Details
ci/circleci: node12-functional Your tests passed on CircleCI!
Details
ci/circleci: node12-integration Your tests passed on CircleCI!
Details
ci/circleci: node12-unit Your tests passed on CircleCI!
Details
security/snyk - __tests__/e2e/package.json (ArkEcosystem) No manifest changes detected
security/snyk - deprecated/core-graphql/package.json (ArkEcosystem) No manifest changes detected
security/snyk - deprecated/core-json-rpc/package.json (ArkEcosystem) No manifest changes detected
security/snyk - deprecated/core-snapshots-cli/package.json (ArkEcosystem) No manifest changes detected
security/snyk - package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-api/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-blockchain/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-container/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database-postgres/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-elasticsearch/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-airbrake/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-bugsnag/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-raygun/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-rollbar/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-sentry/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-event-emitter/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-exchange-json-rpc/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-explorer/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-forger/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-http-utils/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-interfaces/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-jest-matchers/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-pino/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-signale/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-winston/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-new-relic/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-p2p/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-snapshots/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-state/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-tester-cli/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transaction-pool/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transactions/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-utils/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-vote-report/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-wallet-api/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-webhooks/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/crypto/package.json (ArkEcosystem) No manifest changes detected

@ArkEcosystemBot ArkEcosystemBot deleted the feat/core-transactions/dependencies branch Aug 2, 2019

vasild added a commit that referenced this pull request Aug 2, 2019

Merge remote-tracking branch 'ArkEcosystem/core/2.6' into add-nonce-t…
…o-db

* ArkEcosystem/core/2.6:
  build(crypto): configure rollup (#2853)
  feat: transaction type dependencies (#2859)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.