From 2195684c8e58e1f2d6b54cf4e6331a65db411d56 Mon Sep 17 00:00:00 2001 From: supaiku Date: Thu, 26 Sep 2019 04:17:44 +0200 Subject: [PATCH 1/4] feat: allow CLI command configurations --- .../core-container/__stubs__/config/app.js | 39 +++++++++++++++++++ __tests__/utils/config/testnet/app.js | 39 +++++++++++++++++++ __tests__/utils/config/unitnet/app.js | 39 +++++++++++++++++++ packages/core/bin/config/devnet/app.js | 39 +++++++++++++++++++ packages/core/bin/config/mainnet/app.js | 39 +++++++++++++++++++ packages/core/bin/config/testnet/app.js | 39 +++++++++++++++++++ packages/core/package.json | 3 ++ packages/core/src/commands/core/run.ts | 22 +++++++---- packages/core/src/commands/forger/run.ts | 30 ++++++++------ packages/core/src/commands/relay/run.ts | 22 +++++++---- packages/core/src/helpers/replay.ts | 30 ++++++++------ packages/core/src/helpers/snapshot.ts | 24 +++++++----- packages/core/src/utils.ts | 19 ++++++++- 13 files changed, 334 insertions(+), 50 deletions(-) create mode 100644 __tests__/unit/core-container/__stubs__/config/app.js create mode 100644 __tests__/utils/config/testnet/app.js create mode 100644 __tests__/utils/config/unitnet/app.js create mode 100644 packages/core/bin/config/devnet/app.js create mode 100644 packages/core/bin/config/mainnet/app.js create mode 100644 packages/core/bin/config/testnet/app.js diff --git a/__tests__/unit/core-container/__stubs__/config/app.js b/__tests__/unit/core-container/__stubs__/config/app.js new file mode 100644 index 0000000000..64133b4c94 --- /dev/null +++ b/__tests__/unit/core-container/__stubs__/config/app.js @@ -0,0 +1,39 @@ +module.exports = { + cli: { + core: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + relay: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + forger: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + chain: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + snapshot: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + }, +} \ No newline at end of file diff --git a/__tests__/utils/config/testnet/app.js b/__tests__/utils/config/testnet/app.js new file mode 100644 index 0000000000..64133b4c94 --- /dev/null +++ b/__tests__/utils/config/testnet/app.js @@ -0,0 +1,39 @@ +module.exports = { + cli: { + core: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + relay: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + forger: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + chain: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + snapshot: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + }, +} \ No newline at end of file diff --git a/__tests__/utils/config/unitnet/app.js b/__tests__/utils/config/unitnet/app.js new file mode 100644 index 0000000000..64133b4c94 --- /dev/null +++ b/__tests__/utils/config/unitnet/app.js @@ -0,0 +1,39 @@ +module.exports = { + cli: { + core: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + relay: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + forger: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + chain: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + snapshot: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + }, +} \ No newline at end of file diff --git a/packages/core/bin/config/devnet/app.js b/packages/core/bin/config/devnet/app.js new file mode 100644 index 0000000000..64133b4c94 --- /dev/null +++ b/packages/core/bin/config/devnet/app.js @@ -0,0 +1,39 @@ +module.exports = { + cli: { + core: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + relay: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + forger: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + chain: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + snapshot: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + }, +} \ No newline at end of file diff --git a/packages/core/bin/config/mainnet/app.js b/packages/core/bin/config/mainnet/app.js new file mode 100644 index 0000000000..64133b4c94 --- /dev/null +++ b/packages/core/bin/config/mainnet/app.js @@ -0,0 +1,39 @@ +module.exports = { + cli: { + core: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + relay: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + forger: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + chain: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + snapshot: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + }, +} \ No newline at end of file diff --git a/packages/core/bin/config/testnet/app.js b/packages/core/bin/config/testnet/app.js new file mode 100644 index 0000000000..64133b4c94 --- /dev/null +++ b/packages/core/bin/config/testnet/app.js @@ -0,0 +1,39 @@ +module.exports = { + cli: { + core: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + relay: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + forger: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + chain: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + snapshot: { + run: { + plugins: { + include: ["@arkecosystem/core-marketplace"], + }, + }, + }, + }, +} \ No newline at end of file diff --git a/packages/core/package.json b/packages/core/package.json index 1a533c28bb..57d54f6aa9 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -76,6 +76,8 @@ "cli-table3": "^0.5.1", "cli-ux": "^5.3.1", "dayjs": "^1.8.15", + "deepmerge": "^4.0.0", + "dottie": "^2.0.1", "env-paths": "^2.2.0", "envfile": "^3.0.0", "execa": "^2.0.3", @@ -96,6 +98,7 @@ "@types/bip39": "^2.4.2", "@types/bytebuffer": "^5.0.40", "@types/cli-progress": "^1.8.1", + "@types/dottie": "^2.0.3", "@types/execa": "^0.9.0", "@types/fast-levenshtein": "^0.0.1", "@types/fs-extra": "^8.0.0", diff --git a/packages/core/src/commands/core/run.ts b/packages/core/src/commands/core/run.ts index be58a86058..267b69746c 100644 --- a/packages/core/src/commands/core/run.ts +++ b/packages/core/src/commands/core/run.ts @@ -1,6 +1,8 @@ import { app } from "@arkecosystem/core-container"; import { flags } from "@oclif/command"; +import deepmerge from "deepmerge"; import { CommandFlags } from "../../types"; +import { getCliConfig } from "../../utils"; import { BaseCommand } from "../command"; export class RunCommand extends BaseCommand { @@ -43,14 +45,18 @@ $ ark core:run --launchMode=seed public async run(): Promise { const { flags } = await this.parseWithNetwork(RunCommand); - await this.buildApplication(app, flags, { - options: { - "@arkecosystem/core-p2p": this.buildPeerOptions(flags), - "@arkecosystem/core-blockchain": { - networkStart: flags.networkStart, + await this.buildApplication( + app, + flags, + deepmerge(getCliConfig(flags), { + options: { + "@arkecosystem/core-p2p": this.buildPeerOptions(flags), + "@arkecosystem/core-blockchain": { + networkStart: flags.networkStart, + }, + "@arkecosystem/core-forger": await this.buildBIP38(flags), }, - "@arkecosystem/core-forger": await this.buildBIP38(flags), - }, - }); + }), + ); } } diff --git a/packages/core/src/commands/forger/run.ts b/packages/core/src/commands/forger/run.ts index 976c5a37a6..26e16367fe 100644 --- a/packages/core/src/commands/forger/run.ts +++ b/packages/core/src/commands/forger/run.ts @@ -1,6 +1,8 @@ import { app } from "@arkecosystem/core-container"; import { flags } from "@oclif/command"; +import deepmerge from "deepmerge"; import { CommandFlags } from "../../types"; +import { getCliConfig } from "../../utils"; import { BaseCommand } from "../command"; export class RunCommand extends BaseCommand { @@ -26,17 +28,21 @@ $ ark forger:run --bip38="..." --password="..." public async run(): Promise { const { flags } = await this.parseWithNetwork(RunCommand); - await this.buildApplication(app, flags, { - include: [ - "@arkecosystem/core-event-emitter", - "@arkecosystem/core-config", - "@arkecosystem/core-logger", - "@arkecosystem/core-logger-pino", - "@arkecosystem/core-forger", - ], - options: { - "@arkecosystem/core-forger": await this.buildBIP38(flags), - }, - }); + await this.buildApplication( + app, + flags, + deepmerge(getCliConfig(flags), { + include: [ + "@arkecosystem/core-event-emitter", + "@arkecosystem/core-config", + "@arkecosystem/core-logger", + "@arkecosystem/core-logger-pino", + "@arkecosystem/core-forger", + ], + options: { + "@arkecosystem/core-forger": await this.buildBIP38(flags), + }, + }), + ); } } diff --git a/packages/core/src/commands/relay/run.ts b/packages/core/src/commands/relay/run.ts index d65984c8d5..3c951f35a2 100644 --- a/packages/core/src/commands/relay/run.ts +++ b/packages/core/src/commands/relay/run.ts @@ -1,6 +1,8 @@ import { app } from "@arkecosystem/core-container"; import { flags } from "@oclif/command"; +import deepmerge from "deepmerge"; import { CommandFlags } from "../../types"; +import { getCliConfig } from "../../utils"; import { BaseCommand } from "../command"; export class RunCommand extends BaseCommand { @@ -42,14 +44,18 @@ $ ark relay:run --launchMode=seed public async run(): Promise { const { flags } = await this.parseWithNetwork(RunCommand); - await super.buildApplication(app, flags, { - exclude: ["@arkecosystem/core-forger"], - options: { - "@arkecosystem/core-p2p": this.buildPeerOptions(flags), - "@arkecosystem/core-blockchain": { - networkStart: flags.networkStart, + await super.buildApplication( + app, + flags, + deepmerge(getCliConfig(flags), { + exclude: ["@arkecosystem/core-forger"], + options: { + "@arkecosystem/core-p2p": this.buildPeerOptions(flags), + "@arkecosystem/core-blockchain": { + networkStart: flags.networkStart, + }, }, - }, - }); + }), + ); } } diff --git a/packages/core/src/helpers/replay.ts b/packages/core/src/helpers/replay.ts index a122544258..1ee8ec4a73 100644 --- a/packages/core/src/helpers/replay.ts +++ b/packages/core/src/helpers/replay.ts @@ -1,22 +1,28 @@ import { app } from "@arkecosystem/core-container"; import { Container } from "@arkecosystem/core-interfaces"; +import deepmerge from "deepmerge"; +import { getCliConfig } from "../utils"; // tslint:disable-next-line:no-var-requires const { version } = require("../../package.json"); export const setUpLite = async (options): Promise => { - await app.setUp(version, options, { - options: { - "@arkecosystem/core-blockchain": { replay: true }, - }, - include: [ - "@arkecosystem/core-event-emitter", - "@arkecosystem/core-logger-pino", - "@arkecosystem/core-state", - "@arkecosystem/core-database-postgres", - "@arkecosystem/core-blockchain", - ], - }); + await app.setUp( + version, + options, + deepmerge(getCliConfig(options), { + options: { + "@arkecosystem/core-blockchain": { replay: true }, + }, + include: [ + "@arkecosystem/core-event-emitter", + "@arkecosystem/core-logger-pino", + "@arkecosystem/core-state", + "@arkecosystem/core-database-postgres", + "@arkecosystem/core-blockchain", + ], + }), + ); return app; }; diff --git a/packages/core/src/helpers/snapshot.ts b/packages/core/src/helpers/snapshot.ts index ca0a996350..4416beae9f 100644 --- a/packages/core/src/helpers/snapshot.ts +++ b/packages/core/src/helpers/snapshot.ts @@ -1,22 +1,28 @@ import { app } from "@arkecosystem/core-container"; import { Container } from "@arkecosystem/core-interfaces"; +import deepmerge from "deepmerge"; import { lstatSync, readdirSync } from "fs"; import prompts from "prompts"; import { CommandFlags } from "../types"; +import { getCliConfig } from "../utils"; // tslint:disable-next-line:no-var-requires const { version } = require("../../package.json"); export const setUpLite = async (options): Promise => { - await app.setUp(version, options, { - include: [ - "@arkecosystem/core-event-emitter", - "@arkecosystem/core-logger-pino", - "@arkecosystem/core-state", - "@arkecosystem/core-database-postgres", - "@arkecosystem/core-snapshots", - ], - }); + await app.setUp( + version, + options, + deepmerge(getCliConfig(options), { + include: [ + "@arkecosystem/core-event-emitter", + "@arkecosystem/core-logger-pino", + "@arkecosystem/core-state", + "@arkecosystem/core-database-postgres", + "@arkecosystem/core-snapshots", + ], + }), + ); return app; }; diff --git a/packages/core/src/utils.ts b/packages/core/src/utils.ts index e690341190..0d18c515cd 100644 --- a/packages/core/src/utils.ts +++ b/packages/core/src/utils.ts @@ -1,7 +1,9 @@ import Table from "cli-table3"; +import dottie from "dottie"; import envfile from "envfile"; import { writeFileSync } from "fs-extra"; import { existsSync } from "fs-extra"; +import { resolve } from "path"; import { EnvironmentVars } from "./types"; export const renderTable = (head: string[], callback: any): void => { @@ -17,7 +19,7 @@ export const renderTable = (head: string[], callback: any): void => { export const updateEnvironmentVariables = (envFile: string, variables: EnvironmentVars): void => { if (!existsSync(envFile)) { - this.error(`No environment file found at ${envFile}`); + throw new Error(`No environment file found at ${envFile}`); } const env: Record = envfile.parseFileSync(envFile); @@ -28,3 +30,18 @@ export const updateEnvironmentVariables = (envFile: string, variables: Environme writeFileSync(envFile, envfile.stringifySync(env)); }; + +export const getCliConfig = (options: Record, defaultValue = {}): Record => { + const configPath: string = `${process.env.CORE_PATH_CONFIG}/app.js`; + if (!existsSync(configPath)) { + throw new Error(`${configPath} does not exist.`); + } + + const key: string = `cli.${options.suffix}.run.plugins`; + const configuration = require(resolve(configPath)); + if (!dottie.exists(configuration, key)) { + return defaultValue; + } + + return dottie.get(configuration, key); +}; From e90141bb2c56422409244a6e88468babd3bb262b Mon Sep 17 00:00:00 2001 From: supaiku Date: Fri, 27 Sep 2019 06:05:05 +0200 Subject: [PATCH 2/4] refactor: return default instead of throwing when missing app.js --- packages/core/src/utils.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/utils.ts b/packages/core/src/utils.ts index 0d18c515cd..0676a9a730 100644 --- a/packages/core/src/utils.ts +++ b/packages/core/src/utils.ts @@ -34,7 +34,7 @@ export const updateEnvironmentVariables = (envFile: string, variables: Environme export const getCliConfig = (options: Record, defaultValue = {}): Record => { const configPath: string = `${process.env.CORE_PATH_CONFIG}/app.js`; if (!existsSync(configPath)) { - throw new Error(`${configPath} does not exist.`); + return defaultValue; } const key: string = `cli.${options.suffix}.run.plugins`; From c582c9ab4d6b00c308ccc3301ac70376ac147146 Mon Sep 17 00:00:00 2001 From: supaiku Date: Sat, 28 Sep 2019 02:43:20 +0200 Subject: [PATCH 3/4] refactor: core-marketplace -> core-magistrate-transactions --- __tests__/unit/core-container/__stubs__/config/app.js | 10 +++++----- __tests__/utils/config/testnet/app.js | 10 +++++----- __tests__/utils/config/unitnet/app.js | 10 +++++----- packages/core-api/src/handlers/index.ts | 2 +- packages/core/bin/config/devnet/app.js | 10 +++++----- packages/core/bin/config/mainnet/app.js | 10 +++++----- packages/core/bin/config/testnet/app.js | 10 +++++----- 7 files changed, 31 insertions(+), 31 deletions(-) diff --git a/__tests__/unit/core-container/__stubs__/config/app.js b/__tests__/unit/core-container/__stubs__/config/app.js index 64133b4c94..e14163f34a 100644 --- a/__tests__/unit/core-container/__stubs__/config/app.js +++ b/__tests__/unit/core-container/__stubs__/config/app.js @@ -3,35 +3,35 @@ module.exports = { core: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, relay: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, forger: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, chain: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, snapshot: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, diff --git a/__tests__/utils/config/testnet/app.js b/__tests__/utils/config/testnet/app.js index 64133b4c94..e14163f34a 100644 --- a/__tests__/utils/config/testnet/app.js +++ b/__tests__/utils/config/testnet/app.js @@ -3,35 +3,35 @@ module.exports = { core: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, relay: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, forger: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, chain: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, snapshot: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, diff --git a/__tests__/utils/config/unitnet/app.js b/__tests__/utils/config/unitnet/app.js index 64133b4c94..e14163f34a 100644 --- a/__tests__/utils/config/unitnet/app.js +++ b/__tests__/utils/config/unitnet/app.js @@ -3,35 +3,35 @@ module.exports = { core: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, relay: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, forger: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, chain: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, snapshot: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, diff --git a/packages/core-api/src/handlers/index.ts b/packages/core-api/src/handlers/index.ts index c777dc274d..a15596cd04 100644 --- a/packages/core-api/src/handlers/index.ts +++ b/packages/core-api/src/handlers/index.ts @@ -22,7 +22,7 @@ export = { } // TODO: hook into core-api instead in V3 - if (app.has("core-marketplace")) { + if (app.has("core-magistrate-transactions")) { Businesses.register(server); Bridgechains.register(server); } diff --git a/packages/core/bin/config/devnet/app.js b/packages/core/bin/config/devnet/app.js index 64133b4c94..e14163f34a 100644 --- a/packages/core/bin/config/devnet/app.js +++ b/packages/core/bin/config/devnet/app.js @@ -3,35 +3,35 @@ module.exports = { core: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, relay: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, forger: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, chain: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, snapshot: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, diff --git a/packages/core/bin/config/mainnet/app.js b/packages/core/bin/config/mainnet/app.js index 64133b4c94..e14163f34a 100644 --- a/packages/core/bin/config/mainnet/app.js +++ b/packages/core/bin/config/mainnet/app.js @@ -3,35 +3,35 @@ module.exports = { core: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, relay: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, forger: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, chain: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, snapshot: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, diff --git a/packages/core/bin/config/testnet/app.js b/packages/core/bin/config/testnet/app.js index 64133b4c94..e14163f34a 100644 --- a/packages/core/bin/config/testnet/app.js +++ b/packages/core/bin/config/testnet/app.js @@ -3,35 +3,35 @@ module.exports = { core: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, relay: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, forger: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, chain: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, snapshot: { run: { plugins: { - include: ["@arkecosystem/core-marketplace"], + include: ["@arkecosystem/core-magistrate-transactions"], }, }, }, From 81f0954b413788c2aac981f2d00d6fc941968492 Mon Sep 17 00:00:00 2001 From: supaiku Date: Sat, 28 Sep 2019 03:14:53 +0200 Subject: [PATCH 4/4] fix: core run command --- packages/core/src/commands/core/run.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/core/src/commands/core/run.ts b/packages/core/src/commands/core/run.ts index 267b69746c..991501c387 100644 --- a/packages/core/src/commands/core/run.ts +++ b/packages/core/src/commands/core/run.ts @@ -49,6 +49,7 @@ $ ark core:run --launchMode=seed app, flags, deepmerge(getCliConfig(flags), { + exclude: [], options: { "@arkecosystem/core-p2p": this.buildPeerOptions(flags), "@arkecosystem/core-blockchain": {