Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core-transactions): htlc bootstrap #3023

Merged
merged 3 commits into from Oct 5, 2019

Conversation

@supaiku0
Copy link
Contributor

commented Oct 5, 2019

Summary

Optimizes the HTLC bootstrap by excluding claimed/refunded locks and ensuring that each wallet is only indexed once.

Before:

[2019-10-05 01:13:50.419] INFO : State Generation - Step 10 of 20: DelegateResignation
[2019-10-05 01:13:50.458] INFO : State Generation - Step 11 of 20: HtlcLock
[2019-10-05 01:14:30.826] INFO : State Generation - Step 12 of 20: HtlcClaim
[2019-10-05 01:14:41.115] INFO : State Generation - Step 13 of 20: HtlcRefund
[2019-10-05 01:14:41.217] INFO : State Generation - Step 14 of 20: BusinessRegistration

After:

[2019-10-05 01:15:06.293] INFO : State Generation - Step 10 of 20: DelegateResignation
[2019-10-05 01:15:06.326] INFO : State Generation - Step 11 of 20: HtlcLock
[2019-10-05 01:15:06.611] INFO : State Generation - Step 12 of 20: HtlcClaim
[2019-10-05 01:15:06.670] INFO : State Generation - Step 13 of 20: HtlcRefund
[2019-10-05 01:15:06.685] INFO : State Generation - Step 14 of 20: BusinessRegistration

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged
@codecov

This comment has been minimized.

Copy link

commented Oct 5, 2019

Codecov Report

Merging #3023 into develop will increase coverage by 0.05%.
The diff coverage is 18.91%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3023      +/-   ##
===========================================
+ Coverage    65.83%   65.88%   +0.05%     
===========================================
  Files          424      424              
  Lines        10167    10162       -5     
  Branches       538      538              
===========================================
+ Hits          6693     6695       +2     
+ Misses        3428     3422       -6     
+ Partials        46       45       -1
Impacted Files Coverage Δ
...database-postgres/src/repositories/transactions.ts 22.8% <0%> (-1.27%) ⬇️
...ckages/core-transactions/src/transaction-reader.ts 8.33% <0%> (ø) ⬆️
...ckages/core-transactions/src/handlers/htlc-lock.ts 70.21% <0%> (-2.13%) ⬇️
...c/repositories/transactions-business-repository.ts 83.07% <0%> (-4.02%) ⬇️
...ages/core-transactions/src/handlers/htlc-refund.ts 85.33% <37.5%> (+6.58%) ⬆️
...kages/core-transactions/src/handlers/htlc-claim.ts 86.74% <44.44%> (+6.97%) ⬆️
packages/core-api/src/plugins/pagination/ext.ts 81.81% <0%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cdb728...c513903. Read the comment docs.

@faustbrian faustbrian merged commit ea1dea0 into develop Oct 5, 2019
81 of 83 checks passed
81 of 83 checks passed
crypto (10.x)
Details
bridgechain-registration (10.x)
Details
unit (10.x)
Details
crypto (12.x)
Details
bridgechain-registration (12.x)
Details
unit (12.x)
Details
bridgechain-resignation (10.x)
Details
integration (10.x)
Details
bridgechain-resignation (12.x)
Details
integration (12.x)
Details
bridgechain-update (10.x)
Details
e2e (10.x)
Details
bridgechain-update (12.x)
Details
e2e (12.x)
Details
business-registration (10.x)
Details
business-registration (12.x)
Details
business-resignation (10.x)
Details
business-resignation (12.x)
Details
business-update (10.x)
Details
business-update (12.x)
Details
delegate-registration (10.x)
Details
delegate-registration (12.x)
Details
delegate-resignation (10.x)
Details
delegate-resignation (12.x)
Details
htlc-claim (10.x)
Details
htlc-claim (12.x)
Details
htlc-lock (10.x)
Details
htlc-lock (12.x)
Details
htlc-refund (10.x)
Details
htlc-refund (12.x)
Details
ipfs (10.x)
Details
ipfs (12.x)
Details
multi-payment (10.x)
Details
multi-payment (12.x)
Details
multi-signature-registration (10.x)
Details
multi-signature-registration (12.x)
Details
second-signature-registration (10.x)
Details
second-signature-registration (12.x)
Details
transfer (10.x)
Details
transfer (12.x)
Details
vote (10.x)
Details
vote (12.x)
Details
codeclimate 2 issues to fix
Details
codecov/patch 18.91% of diff hit (target 65.83%)
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
codecov/project 65.88% (+0.05%) compared to 3cdb728
Details
security/snyk - __tests__/e2e/package.json (ArkEcosystem) No manifest changes detected
security/snyk - package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-api/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-blockchain/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-container/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database-postgres/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-elasticsearch/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-airbrake/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-bugsnag/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-raygun/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-rollbar/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-sentry/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-event-emitter/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-exchange-json-rpc/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-explorer/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-forger/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-http-utils/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-interfaces/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-jest-matchers/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-pino/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-signale/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-winston/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-new-relic/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-p2p/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-snapshots/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-state/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-tester-cli/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transaction-pool/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transactions/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-utils/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-vote-report/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-wallet-api/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-webhooks/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/crypto/package.json (ArkEcosystem) No manifest changes detected
@ArkEcosystemBot ArkEcosystemBot deleted the perf/htlc-bootstrap branch Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.